Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(email): restrict email change. Fixes MA-173 #227

Merged
merged 3 commits into from
Feb 10, 2021
Merged

fix(email): restrict email change. Fixes MA-173 #227

merged 3 commits into from
Feb 10, 2021

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Feb 10, 2021

No description provided.

@WikiRik WikiRik requested a review from a team February 10, 2021 12:06
@serge1peshcoff
Copy link
Member

what do you think of moving this to MailChange's validation? this seems more right, as IMO these kind of checks do not belong in controllers, but in models instead

@WikiRik
Copy link
Member Author

WikiRik commented Feb 10, 2021

what do you think of moving this to MailChange's validation? this seems more right, as IMO these kind of checks do not belong in controllers, but in models instead

That's actually a very good idea. I forgot that MailChange has its own model.

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #227 (80980a2) into master (65cd775) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #227   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1332      1333    +1     
  Branches       208       209    +1     
=========================================
+ Hits          1332      1333    +1
Impacted Files Coverage Δ
lib/constants.js 100.00% <ø> (ø)
models/MailChange.js 100.00% <100.00%> (ø)
models/User.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bafba1...80980a2. Read the comment docs.

serge1peshcoff
serge1peshcoff approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@serge1peshcoff serge1peshcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WikiRik WikiRik merged commit 85d7dd1 into master Feb 10, 2021
@WikiRik WikiRik deleted the restrict-email-change branch February 10, 2021 12:46
serge1peshcoff pushed a commit that referenced this pull request Feb 10, 2021
@semantic-release-bot
chore(release): 1.31.5 [skip ci]
16f94fd 
## [1.31.5](1.31.4...1.31.5) (2021-02-10)

### Bug Fixes

* **email:** restrict email change. Fixes MA-173 ([#227](#227)) ([85d7dd1](85d7dd1))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.31.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serge1peshcoff serge1peshcoff serge1peshcoff approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WikiRik @serge1peshcoff