Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(members): add endpoints for searching and retrieving email #249

Merged
merged 4 commits into from
Mar 31, 2021

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Mar 4, 2021

Frontend and other modules will be updated later as well, but nothing will break since only new endpoints are added. searchAllUsers will be used for adding members to a body and other places where you want to add people but don't need all the additional data of that user, currently it all requires view:member for that. getUsersEmail is for the massmailer so with one request we get all current emails.

@WikiRik WikiRik requested review from serge1peshcoff and a team March 4, 2021 22:22
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #249 (2f8f3b6) into master (753ebaa) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #249   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1337      1356   +19     
  Branches       211       215    +4     
=========================================
+ Hits          1337      1356   +19     
Impacted Files Coverage Δ
lib/server.js 100.00% <100.00%> (ø)
middlewares/members.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753ebaa...2f8f3b6. Read the comment docs.

middlewares/members.js Outdated Show resolved Hide resolved
@WikiRik WikiRik marked this pull request as ready for review March 20, 2021 17:07
@WikiRik WikiRik merged commit 020ebe1 into master Mar 31, 2021
@WikiRik WikiRik deleted the search-and-get-mail-users branch March 31, 2021 11:12
serge1peshcoff pushed a commit that referenced this pull request Mar 31, 2021
# [1.35.0](1.34.1...1.35.0) (2021-03-31)

### Features

* **members:** add endpoints for searching and retrieving email ([#249](#249)) ([020ebe1](020ebe1))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants