Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(member): send email when joining first body #278

Merged
merged 6 commits into from
Apr 22, 2021
Merged

Conversation

WikiRik
Copy link
Member

@WikiRik WikiRik commented Apr 5, 2021

Mailer PR is not done yet, but apart from that it should all be good

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #278 (4e8be08) into master (1d895a5) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #278   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         1367      1376    +9     
  Branches       216       218    +2     
=========================================
+ Hits          1367      1376    +9     
Impacted Files Coverage Δ
lib/constants.js 100.00% <ø> (ø)
middlewares/body-memberships.js 100.00% <100.00%> (ø)
middlewares/join-requests.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d895a5...4e8be08. Read the comment docs.

@WikiRik WikiRik marked this pull request as ready for review April 16, 2021 07:13
@WikiRik
Copy link
Member Author

WikiRik commented Apr 16, 2021

Mailer PR is finished and the preview is approved by Vale

Copy link
Member

@serge1peshcoff serge1peshcoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@WikiRik WikiRik merged commit 18a0d31 into master Apr 22, 2021
@WikiRik WikiRik deleted the new-member-email branch April 22, 2021 16:02
serge1peshcoff pushed a commit that referenced this pull request Apr 22, 2021
# [1.36.0](1.35.0...1.36.0) (2021-04-22)

### Features

* **member:** send email when joining first body ([#278](#278)) ([18a0d31](18a0d31))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.36.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants