fix(logging): log info and above by default #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1422 1422
Branches 227 227
=========================================
Hits 1422 1422 Continue to review full report at Codecov.
|
| @@ -16,7 +16,7 @@ const config = { | |||
| }, | |||
| logger: { | |||
| silent: false, | |||
| level: process.env.LOGLEVEL || 'debug' | |||
| level: process.env.LOGLEVEL || 'info' | |||
There was a problem hiding this comment.
better to override it at production config and leave the default as debug, we only need info in production
serge1peshcoff
pushed a commit
that referenced
this pull request
Aug 5, 2021
## [1.36.3](1.36.2...1.36.3) (2021-08-05) ### Bug Fixes * **logging:** Log info and above by default ([#327](#327)) ([a72b10b](a72b10b))
|
🎉 This PR is included in version 1.36.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@serge1peshcoff apparently LOGLEVEL is not set in .env so it does debug. Apart from adding it to .env I think it's good if the default level is also info on production