-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(general): allow listing and confirming users manually. Fixes MA-77 #152
Conversation
Codecov Report
@@ Coverage Diff @@
## master #152 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1309 1321 +12
Branches 200 202 +2
=========================================
+ Hits 1309 1321 +12
Continue to review full report at Codecov.
|
test/api/users-confirmation.test.js
Outdated
const user = await generator.createUser({ superadmin: true }); | ||
const token = await generator.createAccessToken({}, user); | ||
|
||
await generator.createPermission({ scope: 'local', action: 'confirm', object: 'member' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the scope of the permission local?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yeah, accessing it with local permission doesn't make sense, as the listing is only accessed with the local one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question, but lgtm
# [1.30.0](1.29.0...1.30.0) (2020-10-21) ### Features * **general:** allow listing and confirming users manually. Fixes MA-77 ([#152](#152)) ([8b5fd16](8b5fd16))
🎉 This PR is included in version 1.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
a) added 2 endpoints:
b) added permissions for seeding
c) added tests