fix(user): allow users to choose notification email. Fixes MA-134 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2020
WikiRik
changed the title
WikiRik
requested changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 1329 1332 +3
Branches 207 208 +1
=========================================
+ Hits 1329 1332 +3
Continue to review full report at Codecov.
|
|
All I need to do now is add new tests so that Codecov does not complain about not reached all cases of the if-statement |
WikiRik
force-pushed
the
multiple-emails
branch
from
55735dd
to
3f72531
Compare
|
Okay, so I added a test but it failed of course. We need #184 to be merged first |
WikiRik
force-pushed
the
multiple-emails
branch
from
3f72531
to
f1d75be
Compare
WikiRik
approved these changes
Dec 9, 2020
WikiRik
changed the title
serge1peshcoff
pushed a commit
that referenced
this pull request
Feb 8, 2021
## [1.31.3](1.31.2...1.31.3) (2021-02-08) ### Bug Fixes * **user:** allow users to choose notification email. Fixes MA-134 ([#179](#179)) ([353d9d4](353d9d4))
|
🎉 This PR is included in version 1.31.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add backend for #722, fixes issue MA-134