feat(general): join body through campaign

AEGEE · Feb 26, 2020 · a430583 · a430583
1 parent 2bc8680
commit a430583
Show file tree

Hide file tree

Showing 3 changed files with 41 additions and 3 deletions.
diff --git a/lib/permissions-manager.js b/lib/permissions-manager.js
@@ -43,9 +43,9 @@ class PermissionsManager {
         const combinedSplit = combined.split(':');
         if (combinedSplit.length === 2) {
             return [
-                'global:' + combinedSplit,
-                'local:' + combinedSplit,
-                'join_request:' + combinedSplit,
+                'global:' + combined,
+                'local:' + combined,
+                'join_request:' + combined,
             ];
         }
 

diff --git a/middlewares/campaigns.js b/middlewares/campaigns.js
@@ -1,6 +1,7 @@
 const {
     User,
     MailConfirmation,
+    BodyMembership,
     Campaign
 } = require('../models');
 const errors = require('../lib/errors');
@@ -19,6 +20,15 @@ exports.registerUser = async (req, res) => {
         ...req.body,
         campaign_id: campaign.id
     });
+
+    // Adding a person to a body if campaign has the autojoin body.
+    if (campaign.autojoin_body_id) {
+        await BodyMembership.create({
+            user_id: user.id,
+            body_id: campaign.autojoin_body_id
+        });
+    }
+
     const confirmation = await MailConfirmation.createForUser(user.id);
 
     return res.json({

diff --git a/test/api/campaigns-submission.test.js b/test/api/campaigns-submission.test.js
@@ -1,6 +1,7 @@
 const { startServer, stopServer } = require('../../lib/server.js');
 const { request } = require('../scripts/helpers');
 const generator = require('../scripts/generator');
+const { BodyMembership } = require('../../models');
 
 describe('Campaign submission', () => {
     beforeAll(async () => {
@@ -172,4 +173,31 @@ describe('Campaign submission', () => {
         expect(res.body).toHaveProperty('data');
         expect(res.body).not.toHaveProperty('errors');
     });
+
+    test('should create a body membership if autojoin_body_id is provided', async () => {
+        const body = await generator.createBody();
+        const campaign = await generator.createCampaign({ autojoin_body_id: body.id });
+        const user = generator.generateUser();
+
+        const res = await request({
+            uri: '/signup/' + campaign.url,
+            method: 'POST',
+            headers: { 'X-Auth-Token': 'blablabla' },
+            body: user
+        });
+
+        expect(res.statusCode).toEqual(200);
+        expect(res.body.success).toEqual(true);
+        expect(res.body).toHaveProperty('data');
+        expect(res.body).not.toHaveProperty('errors');
+
+        const membershipFromDb = await BodyMembership.findOne({
+            where: {
+                body_id: body.id,
+                user_id: res.body.data.user.id
+            }
+        });
+
+        expect(membershipFromDb).not.toEqual(null);
+    });
 });