fix(users): disallow setting date_of_birth from a future

AEGEE · May 11, 2020 · f6b3e9a · f6b3e9a
1 parent 70a6f2a
commit f6b3e9a
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/models/User.js b/models/User.js
@@ -1,4 +1,5 @@
 const bcrypt = require('bcrypt');
+const moment = require('moment');
 
 const { Sequelize, sequelize } = require('../lib/sequelize');
 const config = require('../config');
@@ -82,7 +83,14 @@ const User = sequelize.define('user', {
     },
     date_of_birth: {
         type: Sequelize.DATEONLY,
-        allowNull: true
+        allowNull: true,
+        validate: {
+            isPast(value) {
+                if (moment().isSameOrBefore(value)) {
+                    throw new Error('Birthday should be in the past.');
+                }
+            }
+        }
     },
     gender: {
         type: Sequelize.STRING,

diff --git a/test/unit/users.test.js b/test/unit/users.test.js
@@ -1,3 +1,5 @@
+const moment = require('moment');
+
 const { startServer, stopServer } = require('../../lib/server.js');
 const generator = require('../scripts/generator');
 const { User } = require('../../models');
@@ -95,6 +97,22 @@ describe('Users testing', () => {
         }
     });
 
+    test('should fail with date_of_birth in the future', async () => {
+        try {
+            const user = generator.generateUser({
+                date_of_birth: moment().add(1, 'year').toDate()
+            });
+            await User.create(user);
+
+            expect(1).toEqual(0);
+        } catch (err) {
+            expect(err).toHaveProperty('errors');
+            expect(err.errors.length).toEqual(1);
+            expect(err.errors[0].type).toEqual('Validation error');
+            expect(err.errors[0].path).toEqual('date_of_birth');
+        }
+    });
+
     test('should normalize fields', async () => {
         const data = generator.generateUser({
             username: '\t\t\tSERGEY\t ',