Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mail): update to field mailer #438

Merged
merged 4 commits into from
Feb 8, 2021
Merged

fix(mail): update to field mailer #438

merged 4 commits into from
Feb 8, 2021

Conversation

LeonVreling
Copy link
Member

Should be merged together with #179

@WikiRik
Copy link
Member

WikiRik commented Nov 25, 2020

@LeonVreling this is failing quite some tests, you sure you did this correctly?

@serge1peshcoff
Copy link
Member

I think JSON mocks should be updated as well, there's notification_email missing there

@WikiRik WikiRik changed the title chore(mail): update to field mailer fix(mail): update to field mailer Nov 26, 2020
@WikiRik WikiRik requested a review from a team November 26, 2020 16:36
@codecov
Copy link

codecov bot commented Nov 26, 2020

Codecov Report

Merging #438 (f905920) into master (6b8e698) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #438   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         1877      1877           
  Branches       342       342           
=========================================
  Hits          1877      1877           
Impacted Files Coverage Δ
lib/applications.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d02848...f905920. Read the comment docs.

@WikiRik WikiRik marked this pull request as ready for review December 10, 2020 10:56
@WikiRik WikiRik merged commit b562efe into master Feb 8, 2021
@WikiRik WikiRik deleted the update-email branch February 8, 2021 13:51
serge1peshcoff pushed a commit that referenced this pull request Feb 8, 2021
## [1.6.5](1.6.4...1.6.5) (2021-02-08)

### Bug Fixes

* **mail:** update to field mailer ([#438](#438)) ([b562efe](b562efe))
@serge1peshcoff
Copy link
Member

🎉 This PR is included in version 1.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants