Confirm if State must be in contract class

[gldeng]

If we want to explore modular contract, we require states to be accessed in other classes which can be used to compose the final contracts.

But we have rule to require state to be only accessible from the contract class. We may need to disable it temporarily so that we can test out our modular contract ideas.

    private List<ValidationResult> ValidateMethod(ModuleDefinition moduleDefinition, MethodDefinition methodDefinition)
    {
        if (!methodDefinition.HasBody)
            return new List<ValidationResult>();
        var isNotContractImplementation = !methodDefinition.DeclaringType.IsContractImplementation();

        var result = new List<ValidationResult>();
        foreach (var instruction in methodDefinition.Body.Instructions.Where(instruction =>
                     _instructionInjector.IdentifyInstruction(instruction)).ToList())
        {
            // TODO: https://github.com/AElfProject/AElf/issues/3387
            if (isNotContractImplementation)
            {
                result.Add(new MethodCallInjectionValidationResult(
                    $"{_instructionInjector.GetType()} validation failed. Updating state in non-contract class is not allowed."
                ).WithInfo(
                    methodDefinition.Name,
                    methodDefinition.DeclaringType.Namespace,
                    methodDefinition.DeclaringType.FullName,
                    null
                ));
            }
            else if (!_instructionInjector.ValidateInstruction(moduleDefinition, instruction))
            {
                result.Add(new MethodCallInjectionValidationResult(
                    $"{_instructionInjector.GetType()} validation failed.").WithInfo(methodDefinition.Name,
                    methodDefinition.DeclaringType.Namespace, methodDefinition.DeclaringType.FullName, null));
            }
        }

        return result;
    }