Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add Second Call to Create Conference #3

Open
dtcooper opened this issue Mar 18, 2021 · 7 comments
Open

Feature request: Add Second Call to Create Conference #3

dtcooper opened this issue Mar 18, 2021 · 7 comments

Comments

@dtcooper
Copy link

Hi there,

I love the feature to add an incoming call directly to an existing conference,

image

However, when only one call A exists (an no conference can exist), the button does not show up to create a conference with the two calls for incoming call B. So the workflow is answer the incoming call B (briefly pausing call A) and manually creating a conference. This can cause a brief "outage" of the audio stream for call A.

The feature request here is to show the button pictured above for incoming calls when only one call exists, perhaps with the copy "Create Conference". Let me know what you think. Thanks!

I can potentially work on this since I'm fluent in Python, but I'm having trouble / have never used XCode if you're willing to help me to get set up there.

Cheers,

David

@adigeo
Copy link
Member

adigeo commented Mar 18, 2021

I can add the Xcode plumbing for this and you can do the Python part, I will let you know when I can make time for it

@dtcooper
Copy link
Author

dtcooper commented Mar 18, 2021

That would be great! @adigeo I may need a tiny bit of handholding getting the project running from source in XCode. Mostly a backend programmer.

@adigeo
Copy link
Member

adigeo commented Mar 20, 2021

The functionality is already there, all of it. The only issue is that the button only appears if there is a conference in progress.

What you want is to start a conference if there was none before.

So you want to modify arround these pieces of code:

    @property
    def isConferencing(self):
        return any(session for session in self.sessionControllersManager.sessionControllers if session.hasStreamOfType("audio") and session.streamHandlerOfType("audio").isConferencing)

You must consider that there many be multiple sessions at the moment the new incoming call comes in and select to which one to add the new streams to.

        elif action == ADD_TO_CONFERENCE:
            NSApp.activateIgnoringOtherApps_(True)

Anyway the chance that you will add the second caller to a new conference is a seldom event, tipically you start a conference and then you add new callers to it. The first join is done explicitelly in the audio panel by rag and drop and is more clear what it does rather than pressing (perhaps accidentaly) on a button that is used very seldom in the main alert panel.

@dtcooper
Copy link
Author

The main issue is the audio of the first caller A briefly cutting out while you create a conference with incoming call B. Use case is running a radio show call board while caller A is still talking. And can't there only be one active session?

@dtcooper
Copy link
Author

dtcooper commented Mar 20, 2021

Any pointers for getting XCode running for newbies? I'm happy to try to make the changes soon.

Opening the project yields,

image

and

image

@dtcooper
Copy link
Author

Bump. Happy Tuesday! 😸

@adigeo
Copy link
Member

adigeo commented Apr 17, 2021

Added missing Blink.entitlements file

You need an apple developer account in order to build Blink.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants