-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"initial_amount" in Finrl.finrl.finrl_meta.env_stock_trading.env_stocktrading.py commented out #495
Comments
It was introduced in PR #491
@XiaoYangLiu-FinRL or @shenlei515 can you provide some more details here? edit: it looks like there is a PR undo the changes: #497 |
It was for the case where you own some share of stock in the beginning day instead of only cash. @dpaiton |
@XiaoYangLiu-FinRL you marked this as closed but the bug is not resolved. With the change described above, many of the tutorials no longer work. If I search the repository for Here's the search url: Just as one example, I'm pretty sure this tutorial will fail: https://github.com/AI4Finance-Foundation/FinRL/blob/master/tutorials/1-Introduction/FinRL_StockTrading_NeurIPS_2018.ipynb |
We recently reorganized after closing this issue! Let us open it to fix it. |
Please see the newest version. Fixed. |
why is the "initial_amount" in Finrl.finrl.finrl_meta.env_stock_trading.env_stocktrading.py commented out?
The text was updated successfully, but these errors were encountered: