Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added avl tree implementation #47

Closed
wants to merge 2 commits into from
Closed

added avl tree implementation #47

wants to merge 2 commits into from

Conversation

kaivalmehta
Copy link

PR Description

This code implements avl trees, insertion and deletion in it. It also adds functionalities of different types of traversals

Related Issue

Closes: #46

Changes Made

List the changes you made in this pull request:

Created the file for and implemented Avl Tree Data structure and several operations in it.

Testing

##Manual Testing
I tested the code with several examples of insertions , testing and covering all the edge cases. One of the test case is given in the code as example usage..

Author

Kaival Mehta (kaivalmehta)

@kaivalmehta
Copy link
Author

@Tinny-Robot If the code is okay can you merge the request? Or do i need to make any changes?

@Tinny-Robot
Copy link
Member

Kaival Mehta (@kaivalmehta),

Thank you for your contribution! Your code appears to be mostly sound, but there are some adjustments required before we can merge it:

  1. Please remove the "Example Usage" section of the code and instead add it to the function docstring.

  2. Add a more meaningful file docstring that includes your name as the author, an overview of the file structure, and references to the resources you used during your contribution.

  3. Ensure that file names and variable names follow the snake_case convention, complying with the Python PEP format.

Also, please remember to star the repository.

Your cooperation in making these changes will be greatly appreciated. If you have any questions or need assistance with these adjustments, please feel free to reach out. Thank you again for your contribution!

Updating as per the sugesstions given
@kaivalmehta
Copy link
Author

I have made the changes, kindly check it

@Tinny-Robot
Copy link
Member

**PR Review: #47 **

Reviewer: @Tinny-Robot

Dear @kaivalmehta,

Apologies for the delayed response. Thank you for your recent contribution. Before we can proceed with the merge, please ensure the following:

  1. Add Proper Class Docstring: Include a comprehensive docstring for the class, highlighting its use cases and intended functionality. This will provide a clear understanding of the purpose and usage of the class for other developers.

  2. Include Proper Test Cases: Ensure that you have added appropriate test cases to validate the functionality of the code. Comprehensive tests help maintain the integrity of the implementation.

  3. Pass the Pylint Test: Make sure that your code passes the Pylint test to adhere to our code quality standards. You can refer to the Pylint documentation for assistance.

  4. Reference Materials: If you used any external resources while working on this task, please provide appropriate references to acknowledge the sources.

Additionally, don't forget to star the repository if you haven't already. Your support is highly appreciated.

Please make the necessary updates to meet these requirements. Feel free to reach out if you have any questions or need further assistance.

Best regards,
@Tinny-Robot

@kaivalmehta kaivalmehta closed this by deleting the head repository Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation of an AVL tree for strict balancing.
2 participants