Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flac tags - don't concatenate artist #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Frnot
Copy link

@Frnot Frnot commented Mar 22, 2023

FLAC tag fields "Artist" and "Album Artist" support multiple entries (relevant spec).
Don't combine multiple artists into a single string to improve support with many different media playing applications.

fixes #4 and at least one issue in https://github.com/yaronzz/Tidal-Media-Downloader
also matches behavior of https://github.com/yaronzz/Tidal-Media-Downloader-PRO

@Frnot Frnot marked this pull request as draft March 22, 2023 14:48
@Frnot Frnot marked this pull request as ready for review March 22, 2023 14:48
@Reasonable-Grape2698
Copy link

What's the behaviour of this for end output? How's it work with Plex? Does Plex pickup the first artist or which?

I've got a similar pull relevant to a similar issue, but it instead uses only the MAIN artist so it's friendly for things like plex

@Frnot
Copy link
Author

Frnot commented Oct 5, 2024

What's the behaviour of this for end output? How's it work with Plex? Does Plex pickup the first artist or which?

I've got a similar pull relevant to a similar issue, but it instead uses only the MAIN artist so it's friendly for things like plex

Plex handles multiple artists just fine. My only complaint is that multiple artists are delimited with a ';' in plexamp. This is somewhat ugly, but still usable. The plexamp devs have ignored my request to change it to ', '. I might reach out again with another request.

@Reasonable-Grape2698
Copy link

Reasonable-Grape2698 commented Oct 6, 2024

What's the behaviour of this for end output? How's it work with Plex? Does Plex pickup the first artist or which?
I've got a similar pull relevant to a similar issue, but it instead uses only the MAIN artist so it's friendly for things like plex

Plex handles multiple artists just fine. My only complaint is that multiple artists are delimited with a ';' in plexamp. This is somewhat ugly, but still usable. The plexamp devs have ignored my request to change it to ', '. I might reach out again with another request.

As is the multiple artists (as a string) result in plex thinking it's one artist and making a folder named "artist1, artist2, artist3"... etc

There's also a glitch where if you use a string as the artist, it still calls the list function then errors. I've made a pull that actually detects if it's a string first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Artist Tags
2 participants