Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDC Source to work with StarKiller Microphysics #13

Open
dwillcox opened this issue Sep 18, 2017 · 1 comment
Open

Update SDC Source to work with StarKiller Microphysics #13

dwillcox opened this issue Sep 18, 2017 · 1 comment
Assignees

Comments

@dwillcox
Copy link
Member

The interface from Source_SDC in Maestro to the burner should be updated to work with the StarKiller Microphysics repository.

The SCIENCE/flame problem is a good test, compile with SDC=t

At present the interface is broken so compilation fails.

@dwillcox
Copy link
Member Author

dwillcox commented Oct 16, 2017

In going through the SDC bits of the integrators in StarKiller Microphysics it is apparent they're set up for a different sort of SDC in Castro than Maestro has. The Maestro SDC only integrates rho*X and rho*h, whereas Castro integrates rho*X, internal energy, and kinetic energy. Maestro also doesn't need to carry around any unevolved variables.

I think a straightforward way to make the integrators work for both cases is to introduce a preprocessor variable SDC_METHOD with the appropriate logic.

On a related note, we could think about whether there are advantages to using h versus e in MAESTRO, and this may depend on whether (rho*h) is a good conserved quantity for extended stars as it is for small scale flames where we have previously run MAESTRO with SDC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant