Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IS-05 v1.1 transport_params schemas don't validate as intended #98

Closed
garethsb opened this issue Oct 11, 2019 · 0 comments · Fixed by #99
Closed

IS-05 v1.1 transport_params schemas don't validate as intended #98

garethsb opened this issue Oct 11, 2019 · 0 comments · Fixed by #99

Comments

@garethsb
Copy link
Contributor

The mechanism by which we introduced the transport parameters for the additional transports' has had the unfortunate side-effect of making unexpected instances validate.

E.g. the following PATCH /single/receivers/{receiverId}/staged request body validates right now

{
  "transport_params": [
    {
      "destination_port": "foo"
    }
  ]
}

That's because although the transport params don't pass the RTP params schema, it does pass the WebSocket params schema, because the schemas don't prohibit additional properties (and have no required properties because it's valid to stage as few params as you like).

Fix PR on the way...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant