Warnings possibly indicating problems

[dzenanz]

This concatenation of strings is discarded:

ANTs/Examples/Atropos.cxx

Lines 1335 to 1344 in 2d3cefa

	std::string("Options include the following: ") +
	std::string(" Socrates: posteriorProbability = (spatialPrior)^priorWeight") +
	std::string("*(likelihood*mrfPrior)^(1-priorWeight), ") + std::string(" Plato: posteriorProbability = 1.0, ") +
	std::string(" Aristotle: posteriorProbability = 1.0, ") +
	std::string(" Sigmoid: posteriorProbability = 1.0, ") /* +
	std::string( " Zeno: posteriorProbability = 1.0\n" ) +
	std::string( " Diogenes: posteriorProbability = 1.0\n" ) +
	std::string( " Thales: posteriorProbability = 1.0\n" ) +
	std::string( " Democritus: posteriorProbability = 1.0.\n" ) */
	;

Maybe a semicolon on the previous line (1334) should be replaced by a plus sign?

Current Visual Studio (17.8.4) reports the following warning:
C:\Dev\ANTs\Examples\sccan.cxx(2593,8): warning C4858: discarding return value: The 'remove' and 'remove_if' algorithms return the iterator past the last element that should be kept. You need to call container.erase(result, container.end()) afterwards. In C++20, 'std::erase' and 'std::erase_if' are simpler replacements for these two steps.
That code should be checked, and if it is OK that line should be replaced by:

std::ignore = std::remove(args.begin(), args.end(), std::string(""));

[ntustison]

Yes, that's correct (i.e., the semi-colon should be replaced by a plus sign).

[dzenanz]

@cookpa There is just one warning when compiling ANTs normally: C:\Dev\ANTs\Examples\sccan.cxx(2593,8): warning C4858: discarding return value. I am not familiar with this code to be able to tell whether we should just ignore the warning.

[cookpa]

This looks like it re-orders the args matrix to put non-empty strings first. It discards the returned iterator. I'm not sure what its purpose is, but possibly something to do with ANTsR or ANTsPy. I think the warning is safe to ignore

ANTs/Examples/sccan.cxx

Line 2593 in 62550fc

std::remove(args.begin(), args.end(), std::string(""));