-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Particle Tracers Delay Problem #104
Comments
The reason I added that delay was so the particles can show up after the explosion has cleared. |
The problem is that you wouldn't see the explosion past a certain distance anyway as while Minecraft renders TNT entities out to that range, it doesn't render the particles of the explosion this means that the tracer particle explosion indicator appears awkwardly late after a crater does Movecraft-Combat already has a setting to disable the explosion indicator within a certain radius which would allow for protection against redundancy if the explosion occurs within normal Minecraft particle rendering But if this delay is necessary in certain cases and uses of the particle tracers, would it be possible for a config setting to be added to adjust the delay? |
Adding a config for the delay should be simple |
Something I also noticed is that sometimes the impact particles don't show up but the tracers do. Is there a limit to how many can spawn? I'm not sure if this is the case because sometimes they don't appear even when dealing with pretty small amounts of TNT. |
Hmm, I'm not sure why they wouldn't show up. The only reason I've noticed so far has been that the explosion particles obstruct the view. |
This is the line yes? All I have to do is just add a setting option for it? |
Yup |
The effect given to the particle tracers is delayed by about 20 ticks after the explosion actually occurs
Suggestion would be to have it appear as soon as the explosion occurs with no delay if possible so particle tracers could be used as a way to see the effects of cannons further out
Movecraft-Combat/src/main/java/net/countercraft/movecraft/combat/features/tracers/TNTTracers.java
Line 157 in e1f391c
The text was updated successfully, but these errors were encountered: