Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particle Tracers Delay Problem #104

Closed
MysteryTimeTrav opened this issue Dec 20, 2022 · 7 comments · Fixed by #115
Closed

Particle Tracers Delay Problem #104

MysteryTimeTrav opened this issue Dec 20, 2022 · 7 comments · Fixed by #115
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@MysteryTimeTrav
Copy link

The effect given to the particle tracers is delayed by about 20 ticks after the explosion actually occurs

Suggestion would be to have it appear as soon as the explosion occurs with no delay if possible so particle tracers could be used as a way to see the effects of cannons further out

@TylerS1066
Copy link
Collaborator

The reason I added that delay was so the particles can show up after the explosion has cleared.

@MysteryTimeTrav
Copy link
Author

The problem is that you wouldn't see the explosion past a certain distance anyway as while Minecraft renders TNT entities out to that range, it doesn't render the particles of the explosion

this means that the tracer particle explosion indicator appears awkwardly late after a crater does

Movecraft-Combat already has a setting to disable the explosion indicator within a certain radius which would allow for protection against redundancy if the explosion occurs within normal Minecraft particle rendering
TracerMinDistance: 15 # Minimum distance at which glowstone tracers are spawned on explosion

But if this delay is necessary in certain cases and uses of the particle tracers, would it be possible for a config setting to be added to adjust the delay?

@TylerS1066
Copy link
Collaborator

Adding a config for the delay should be simple

@TylerS1066 TylerS1066 added enhancement New feature or request good first issue Good for newcomers labels Dec 26, 2022
@MysteryTimeTrav
Copy link
Author

Something I also noticed is that sometimes the impact particles don't show up but the tracers do. Is there a limit to how many can spawn? I'm not sure if this is the case because sometimes they don't appear even when dealing with pretty small amounts of TNT.

@TylerS1066
Copy link
Collaborator

Hmm, I'm not sure why they wouldn't show up. The only reason I've noticed so far has been that the explosion particles obstruct the view.

@goodroach
Copy link
Contributor

@TylerS1066
Copy link
Collaborator

Yup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants