Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged Fires Stop Spreading Upon Craft Movement #500

Closed
MysteryTimeTrav opened this issue Feb 12, 2022 · 3 comments · Fixed by #637
Closed

Merged Fires Stop Spreading Upon Craft Movement #500

MysteryTimeTrav opened this issue Feb 12, 2022 · 3 comments · Fixed by #637
Labels
bug Issues causing negative effects for end users

Comments

@MysteryTimeTrav
Copy link

Describe the bug
Fires that are part of a craft stop spreading upon being moved. This happens even if fire merging is turned off as fires that spread within a ship that take the place of previously present blocks merge and become part of the craft and stop their spread when it moves.

To Reproduce
Steps to reproduce the behavior:

  1. Pilot a craft
  2. Ignite a fire inside and/or outside
  3. Move the ship a bit
  4. Fire stops spreading

Expected behavior
The fires continue to spread within the ship even if it moves.

Screenshots
I don't have any screenshots at the moment but it should apply to all fires ignited on crafts.

Versions (please complete the following information):

  • Movecraft: [Movecraft] Movecraft 8.0.0-a.5
  • Addons: Movecraft-Combat
  • Java 16 - Open J9
  • Minecraft 1.16.5

Additional context
Add any other context about the problem here.

@MysteryTimeTrav MysteryTimeTrav added the bug Issues causing negative effects for end users label Feb 12, 2022
@TylerS1066
Copy link
Contributor

This likely is related to moving tile entity ticks not currently working either, which I now realize doesn't have a reported issue either.

@TylerS1066 TylerS1066 moved this to New in Issue Triage Mar 23, 2022
@TylerS1066 TylerS1066 moved this from New to Ready for Work in Issue Triage Mar 23, 2022
@TylerS1066 TylerS1066 moved this from Ready for Work to In Progress in Issue Triage Nov 20, 2022
@goodroach
Copy link
Contributor

I tested this in my private server in 1.16.5 and it seems to work.

@TylerS1066
Copy link
Contributor

I have as well, I think both 1.14.4 and 1.16.5 have this functioning. I'm going to keep this open for 1.18 and (soon) 1.20, since I believe we'll continue the pattern and focus on every other worldhandler.

@TylerS1066 TylerS1066 mentioned this issue Mar 9, 2024
1 task
@github-project-automation github-project-automation bot moved this from In Progress to Resolved in Issue Triage Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues causing negative effects for end users
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants