Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main Cortex-M55/M85 EWIC registers not present #1618

Open
kjbracey opened this issue Apr 14, 2023 · 4 comments
Open

Main Cortex-M55/M85 EWIC registers not present #1618

kjbracey opened this issue Apr 14, 2023 · 4 comments

Comments

@kjbracey
Copy link
Collaborator

core_cm55.h and core_cm85.h have EWIC and EWIC_Type definitions, but these describe the "EWIC interrupt status access" registers in the core that provide access to the NVIC for the benefit of transferring state to and from the EWIC.

There are no definitions for the EWIC itself at E0047000, which software is more likely to want to access - at a minimum you need to enable it in its control register.

@ghost
Copy link

ghost commented Apr 17, 2023

Hello @kjbracey, thank you for pointing out.
I did not pay enough attention to the usage when adding these registers.

My proposal is to change the current EWIC type and defines from EWIC_Type to EWIC_ISA_Type (EWIC Interrupt status access) and add the EWIC register under EWIC_Type (see chapter A.2 EWIC register summary in Cortex-M55 TRM).

Please let me know you opinion.

@kjbracey
Copy link
Collaborator Author

Yes, that makes sense to me.

@ghost ghost self-assigned this Apr 17, 2023
ghost pushed a commit that referenced this issue Apr 17, 2023
@ghost
Copy link

ghost commented Apr 17, 2023

Hello @kjbracey, please check e04fcc4.

I was not able to add you as reviewer. :-(

ghost pushed a commit that referenced this issue Apr 17, 2023
@kjbracey
Copy link
Collaborator Author

Left some comments on the first version of the commit.

ghost pushed a commit that referenced this issue Apr 17, 2023
JonatanAntoni pushed a commit that referenced this issue Apr 17, 2023
JonatanAntoni pushed a commit to JonatanAntoni/CMSIS_6 that referenced this issue May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants