Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with new ARMv8 MPU attributes #1634

Open
kjbracey opened this issue Jun 9, 2023 · 1 comment
Open

Issues with new ARMv8 MPU attributes #1634

kjbracey opened this issue Jun 9, 2023 · 1 comment

Comments

@kjbracey
Copy link
Collaborator

kjbracey commented Jun 9, 2023

I just noticed the new MPU_ATTR_NORMAL_OUTER_NON_CACHEABLE etc defines.

A few issues with these, in descending order of importance:

  • The TR transient indication is inverted. Bit 3 needs to be set for transient.
  • The 0b binary prefix requires a very recent language standard or a compiler extension.
  • Shouldn't they have an ARM_ prefix to match surrounding defines?
  • But is the OUTER_ and INNER_ necessary?

And as an aside, just for anyone happening to search and end up here - it's not specified anywhere what the "transient" flags of the default memory map are. Apparently the default regions are transient in the M55, which surprised me.

@JonatanAntoni
Copy link
Member

Would you mind raising a PR with your proposed changes?
Perhaps switch over to ARM-software/CMSIS_6 and we leave it unchanged here. Adding ARM_ prefix might be a good idea but would break backward compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants