From 5a00810541699953f6ed1732c8b81fdcde310a58 Mon Sep 17 00:00:00 2001 From: Tarek El-Sherbiny Date: Fri, 9 Aug 2024 15:37:27 +0100 Subject: [PATCH] mod_power_domain/unit_test: fix compiler error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On gcc 13.2.0 the following error is flagged: error: comparison of integer expressions of different signedness: ‘int’ and ‘enum pd_idx’ [-Werror=sign-compare] Positive enum should be compared against unsigned variables. Signed-off-by: Tarek El-Sherbiny --- .../test/mod_power_domain_state_checks_unit_test.c | 10 +++++----- module/power_domain/test/mod_power_domain_unit_test.c | 6 +++--- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/module/power_domain/test/mod_power_domain_state_checks_unit_test.c b/module/power_domain/test/mod_power_domain_state_checks_unit_test.c index 2bad5e542..b47d86a7f 100644 --- a/module/power_domain/test/mod_power_domain_state_checks_unit_test.c +++ b/module/power_domain/test/mod_power_domain_state_checks_unit_test.c @@ -50,7 +50,7 @@ static void init_module_ctx(void) mod_pd_ctx_temp.system_pd_ctx = &mod_pd_ctx_temp.pd_ctx_table[PD_IDX_COUNT - 1]; - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { pd_ctx[i] = pd_ctx_config[i]; fwk_list_init(&pd_ctx[i].children_list); } @@ -58,7 +58,7 @@ static void init_module_ctx(void) static void evaluate_valid_state_mask(void) { - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { for (unsigned int state = 0; state < pd_ctx[i].allowed_state_mask_table_size; state++) { @@ -439,7 +439,7 @@ void test_is_upwards_transition_propagation_true(void) pd->cs_support = true; /* Change the current requested state so a deeper one can be requested */ - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { pd_ctx[i].requested_state = MOD_PD_STATE_ON; } @@ -472,7 +472,7 @@ void test_is_upwards_transition_propagation_no_cs_true(void) pd->cs_support = false; /* Swap this round so a deeper state can be requested */ - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { pd_ctx[i].requested_state = MOD_PD_STATE_ON; } @@ -507,7 +507,7 @@ void test_is_allowed_by_parent_and_children_denied(void) struct pd_ctx *pd = &mod_pd_ctx_temp.pd_ctx_table[PD_IDX_CLUSTER0]; /* Swap this round so a pd can deny it is permitted */ - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { pd_ctx[i].current_state = MOD_PD_STATE_ON; } diff --git a/module/power_domain/test/mod_power_domain_unit_test.c b/module/power_domain/test/mod_power_domain_unit_test.c index 372739727..cb518b38f 100644 --- a/module/power_domain/test/mod_power_domain_unit_test.c +++ b/module/power_domain/test/mod_power_domain_unit_test.c @@ -41,7 +41,7 @@ static void init_module_ctx(void) mod_pd_ctx.pd_count = PD_IDX_COUNT; mod_pd_ctx.system_pd_ctx = &mod_pd_ctx.pd_ctx_table[PD_IDX_COUNT - 1]; - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { pd_ctx[i] = pd_ctx_config[i]; pd_ctx[i].driver_api = &pd_driver; fwk_list_init(&pd_ctx[i].children_list); @@ -50,7 +50,7 @@ static void init_module_ctx(void) static void evaluate_valid_state_mask(void) { - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { for (unsigned int state = 0; state < pd_ctx[i].allowed_state_mask_table_size; state++) { @@ -812,7 +812,7 @@ void test_process_get_state_request_cs(void) pd_ctx[PD_IDX_CLUS0CORE0].composite_state_levels_mask = MOD_PD_CS_STATE_MASK << MOD_PD_CS_LEVEL_SHIFT; - for (int i = 0; i < PD_IDX_COUNT; ++i) { + for (unsigned int i = 0; i < PD_IDX_COUNT; ++i) { pd_ctx[i].current_state = MOD_PD_STATE_ON; }