Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCS ACLE #364

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

GCS ACLE #364

wants to merge 4 commits into from

Conversation

yury-khrustalev
Copy link

@yury-khrustalev yury-khrustalev commented Nov 25, 2024

This is to continue discussion started in #260.


name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.


@yury-khrustalev yury-khrustalev mentioned this pull request Nov 25, 2024
8 tasks
@yury-khrustalev
Copy link
Author

The only difference compared to #260 is use of non-const type for GCS pointer (an relevant change in wording).

at compile time if (1) is true which can be feature tested. With (C)
there is no obvious feature test for the presence of the intrinsics.

The future direction is to make intrinsics available unconditionally
Copy link
Contributor

@DanielKristofKiss DanielKristofKiss Nov 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how other intrinsics are defined already in practice (gcc, clang at least)
Macro just there to indicate to the user the availability of the intrinsics.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarification. I've changed the wording, let me know if it's better now.

Copy link
Contributor

@DanielKristofKiss DanielKristofKiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, just a note from me.
let see what others says.

@yury-khrustalev yury-khrustalev force-pushed the gcs branch 2 times, most recently from 70ac9c6 to a6e18dd Compare December 2, 2024 11:37
Co-authored-by: Yury Khrustalev <yury.khrustalev@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants