Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect 'usage' information in email example program #2337

Closed
irwir opened this issue Jan 8, 2019 · 3 comments
Closed

Incorrect 'usage' information in email example program #2337

irwir opened this issue Jan 8, 2019 · 3 comments

Comments

@irwir
Copy link
Contributor

irwir commented Jan 8, 2019

Description

  • Type: Bug
  • Priority: Minor

Bug

The default port number is 465, but usage string has different hard-coded value 4433.
https://github.com/ARMmbed/mbedtls/blob/fb1972db23da39bd11d4f9c9ea6266eee665605b/programs/ssl/ssl_mail_client.c#L95
https://github.com/ARMmbed/mbedtls/blob/fb1972db23da39bd11d4f9c9ea6266eee665605b/programs/ssl/ssl_mail_client.c#L135

It might be worth to apply this pattern, where appropriate:

     "    server_name=%%s      default: " DFL_SERVER_NAME "\n" \
     "    server_port=%%d      default: " DFL_SERVER_PORT "\n" \

mbed TLS build:
Development branch, all(?) previous versions

@RonEld
Copy link
Contributor

RonEld commented Jan 9, 2019

@irwir Thank you for raising this issue!
Will you be willing to contribute a fix for this issue?

@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2707

@RonEld
Copy link
Contributor

RonEld commented Apr 17, 2019

the PR and backports fixing this issue have been merged, so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants