Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the output of mbedtls_debug_print_ecp for Montgomery curves #4609

Open
gilles-peskine-arm opened this issue Jun 2, 2021 · 0 comments
Open

Improve the output of mbedtls_debug_print_ecp for Montgomery curves #4609

gilles-peskine-arm opened this issue Jun 2, 2021 · 0 comments
Labels
component-tls enhancement good-first-issue Good for newcomers help-wanted This issue is not being actively worked on, but PRs welcome. size-s Estimated task size: small (~2d)

Comments

@gilles-peskine-arm
Copy link
Contributor

mbedtls_debug_print_ecp is prints a point by printing its X and Y coordinates. This is a little weird with Montgomery curves since the internal representation does not use the Y coordinate so it's printing 0.

A minor issue revealed by @lhuang04 in #4578. It triggered the more serious bug #4608.
@gilles-peskine-arm gilles-peskine-arm added enhancement help-wanted This issue is not being actively worked on, but PRs welcome. component-tls good-first-issue Good for newcomers Product Backlog labels Jun 2, 2021
@gilles-peskine-arm gilles-peskine-arm mentioned this issue Jun 2, 2021
Closed
@gilles-peskine-arm gilles-peskine-arm added the size-s Estimated task size: small (~2d) label Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component-tls enhancement good-first-issue Good for newcomers help-wanted This issue is not being actively worked on, but PRs welcome. size-s Estimated task size: small (~2d)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@daverodgman @gilles-peskine-arm @bensze01