Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSR parsing error (mbedtls_x509_csr_parse) #767

Closed
michaelernst opened this issue Jan 18, 2017 · 2 comments · Fixed by #2040
Closed

CSR parsing error (mbedtls_x509_csr_parse) #767

michaelernst opened this issue Jan 18, 2017 · 2 comments · Fixed by #2040
Labels
bug

Comments

@michaelernst
Copy link

Hi guys,

it seems that there is a "problem" with parsing some CSRs using the mbedtls_x509_csr_parse function. If the requests starts with "----BEGIN NEW CERTIFICATE REQUEST----" instead of "----BEGIN CERTIFICATE REQUEST----" (without the new), parsing will fail.

We ran into this problem while parsing CSRs generated by (I guess) Windows machines.

Not that this is a show stopper, but it was definitely not the first thing we were looking for when the errors occurred and only realized it by accident ;).

Best,
Michael
@simonbutcher
Copy link
Contributor

It appears that the Microsoft tool certreq generates the alternative headers that are causing an issue, and that according to the relevant RFC, RFC7468, we are no longer compliant.

Given this is an issue where we're not compliant - this should get some priority.

@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-1166

redtangent added a commit to redtangent/mbedtls that referenced this issue Sep 30, 2018
@redtangent
Add Changelog entry for Mbed-TLS#767
e26e2c8 
Add Changelog entry for fix for alternative header/footers in CSR's.
@redtangent redtangent mentioned this issue Sep 30, 2018
Merged
4 tasks
redtangent added a commit to redtangent/mbedtls that referenced this issue Oct 6, 2018
@redtangent
Add Changelog entry for Mbed-TLS#767
5199227 
Add Changelog entry for fix for alternative header/footers in CSR's.
redtangent added a commit to redtangent/mbedtls that referenced this issue Dec 5, 2018
@redtangent
Add Changelog entry for Mbed-TLS#767
ff719bb 
Add Changelog entry for fix for alternative header/footers in CSR's.
redtangent added a commit to redtangent/mbedtls that referenced this issue Dec 5, 2018
@redtangent
Add Changelog entry for Mbed-TLS#767
f0737ae 
Add Changelog entry for fix for alternative header/footers in CSR's.
This was referenced Dec 5, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for alternative CSR headers/footers redtangent/mbedtls
3 participants
@michaelernst @simonbutcher @ciarmcom