Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

most selftest function declarations are not surrounded by MBEDTLS_SELF_TEST #971

Closed
RonEld opened this issue Jun 19, 2017 · 3 comments
Closed

most selftest function declarations are not surrounded by MBEDTLS_SELF_TEST #971

RonEld opened this issue Jun 19, 2017 · 3 comments
Labels
bug

Comments

@RonEld
Copy link
Contributor

RonEld commented Jun 19, 2017

most of the selftest function declarations are not surrounded by ``#if defined(MBEDTLS_SELF_TEST)` check.
Note: The .c files function implementations are surrounded
sha512.h
aes.h
ctr_drbg.h
ripemd160.h
arc4.h
dhm.h
md5.h
base64.h
xtea.h
x509.h
camelilia.h
pkcs5.h
md2
md4
gcm.h
sha256.h
bignum.h
sha1.h
rsa.h
des.h
@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-1470

RonEld pushed a commit to RonEld/mbedtls that referenced this issue Jun 20, 2017
Add MBEDTLS_SELF_TEST check in header files
ac48a76 
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue Mbed-TLS#971
@RonEld RonEld mentioned this issue Jun 20, 2017
Merged
RonEld pushed a commit to RonEld/mbedtls that referenced this issue Jun 21, 2017
Add MBEDTLS_SELF_TEST check in header files
75a9a96 
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue Mbed-TLS#971
RonEld pushed a commit to RonEld/mbedtls that referenced this issue Jun 21, 2017
Add MBEDTLS_SELF_TEST check in header files
1399836 
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue Mbed-TLS#971
@RonEld
Copy link
Contributor Author

RonEld commented Jun 21, 2017

This is a subset of #660

RonEld pushed a commit to RonEld/mbedtls that referenced this issue Jun 21, 2017
Add MBEDTLS_SELF_TEST check in header files
5af5cbe 
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue Mbed-TLS#971
RonEld pushed a commit to RonEld/mbedtls that referenced this issue May 21, 2018
Add MBEDTLS_SELF_TEST check in header files
fa8f635 
Add the `MBEDTLS_SELF_TEST` precompilation surrounding the self test functions,
which were missing this check in the header files. ( most of the header files were missing this check).
Addresses issue Mbed-TLS#971
gilles-peskine-arm added a commit to gilles-peskine-arm/mbedtls that referenced this issue Oct 12, 2018
@gilles-peskine-arm
SHA3: Declare self_test routines only under MBEDTLS_SELF_TEST
719e738 
Addresses Mbed-TLS#971 for SHA3.
@simonbutcher
Copy link
Contributor

PR #975 has been merged. This issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonbutcher @ciarmcom @RonEld