Remove MD2, MD4, RC4, Blowfish and XTEA #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRodziewicz
added
enhancement
needs-work
needs-ci
TRodziewicz
added
needs: changelog
needs-ci
|
Please remove the merge commit and rebase on top of |
gilles-peskine-arm
added
needs-work
and removed
needs-review
TRodziewicz
force-pushed
the
remove_MD2_MD4_RC4_Blowfish_and_XTEA
branch
from
a7dcd33 to
4f6c032
Compare
TRodziewicz
added
needs-review
TRodziewicz
added
needs-work
and removed
needs-review
TRodziewicz
force-pushed
the
remove_MD2_MD4_RC4_Blowfish_and_XTEA
branch
from
4f6c032 to
9b830e1
Compare
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
TRodziewicz
force-pushed
the
remove_MD2_MD4_RC4_Blowfish_and_XTEA
branch
from
8ff1223 to
8f91c72
Compare
gilles-peskine-arm
requested changes
Jun 17, 2021
gilles-peskine-arm
added
needs-work
and removed
needs-review
Reverting some deleted tests and changing the deprecated algo Deleting deprecated headers from /alt-dummy dir Corrections to the comments Removal of deleted functions from compat-2.x.h Corrections to tests/data_files/Makefile Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
TRodziewicz
force-pushed
the
remove_MD2_MD4_RC4_Blowfish_and_XTEA
branch
from
646424e to
75628d5
Compare
TRodziewicz
added
needs-review
mpg
requested changes
Jun 21, 2021
There was a problem hiding this comment.
Looks pretty good to me, except a few more files that could be removed, and one test case that could be restored.
Also, some of the previous migration guide entries mention MD2 and MD4 - can you edit them in order to remove those references? It makes little sense to keep tell people about md2_starts_ret() being renamed now that it's actually entirely removed :) See docs/3.0-migration-guide.d/rename_the__ret_functions.md and docs/3.0-migration-guide.md
mpg
added
needs-work
and removed
needs-review
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
gilles-peskine-arm
requested changes
Jun 21, 2021
| depends_on:MBEDTLS_ARC4_C:MBEDTLS_CIPHER_MODE_CTR | ||
| # Either INVALID_ARGUMENT or NOT_SUPPORTED would be reasonable here | ||
| cipher_setup:PSA_KEY_TYPE_ARC4:"000102030405060708090a0b0c0d0e0f":PSA_ALG_CTR:PSA_ERROR_NOT_SUPPORTED | ||
| cipher_setup:PSA_KEY_TYPE_CHACHA20:"000102030405060708090a0b0c0d0e0f":PSA_ALG_CTR:PSA_ERROR_NOT_SUPPORTED |
There was a problem hiding this comment.
This is not a good test case because it has two bad things: the key type is incompatible with the algorithm, and the key size is wrong for the key type. So if psa_cipher_setup returns an error code, we don't know if it's for the reason we want. Please change the key data to be 32 bytes instead of 16.
| @@ -1397,7 +1397,7 @@ cipher_setup:PSA_KEY_TYPE_RAW_DATA:"000102030405060708090a0b0c0d0e0f":PSA_ALG_CT | |||
| PSA cipher setup: incompatible key ChaCha20 for CTR | |||
| depends_on:MBEDTLS_ARC4_C:MBEDTLS_CIPHER_MODE_CTR | |||
| # Either INVALID_ARGUMENT or NOT_SUPPORTED would be reasonable here | |||
| cipher_setup:PSA_KEY_TYPE_CHACHA20:"000102030405060708090a0b0c0d0e0f":PSA_ALG_CTR:PSA_ERROR_NOT_SUPPORTED | |||
| cipher_setup:PSA_KEY_TYPE_CHACHA20:"000102030405060708090a0b0c0d0e0f1011121314151617":PSA_ALG_CTR:PSA_ERROR_NOT_SUPPORTED | |||
There was a problem hiding this comment.
This is 24 bytes, not 32
There was a problem hiding this comment.
Ooops! True! 1 sec....
There was a problem hiding this comment.
OK, should be better now.
Signed-off-by: TRodziewicz <tomasz.rodziewicz@mobica.com>
TRodziewicz
force-pushed
the
remove_MD2_MD4_RC4_Blowfish_and_XTEA
branch
from
69f3486 to
4a28ade
Compare
gilles-peskine-arm
approved these changes
Jun 21, 2021
mpg
approved these changes
Jun 22, 2021
mpg
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TRodziewicz tomasz.rodziewicz@mobica.com
Description
Remove the obsolete and niche cryptographic primitives from Mbed TLS 3.0, namely MD2, MD4, RC4, Blowfish and XTEA.
Fixes: #4084
Status
IN DEVELOPMENT
Requires Backporting
NO
Todos