Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arki-server hangs forever if filter process hangs on exit #301

Closed
spanezz opened this issue Apr 26, 2023 · 3 comments
Closed

arki-server hangs forever if filter process hangs on exit #301

spanezz opened this issue Apr 26, 2023 · 3 comments
Assignees
Labels

Comments

@spanezz
Copy link
Contributor

spanezz commented Apr 26, 2023

While reads and writes towards the child filter process should use a tmeout to prevent hanging forever, wait()ing for the child process to exit after closing its input can (and does) currently wait forever.

This should be changed to wait with a timeout, and if the timeout expires then doing the usual SIGTERM/SIGKILL escalation to stop che child process

@spanezz spanezz added the bug label Apr 26, 2023
@spanezz spanezz self-assigned this Apr 26, 2023
@spanezz
Copy link
Contributor Author

spanezz commented Apr 26, 2023

From here the cleanest way to get a timeout on a wait() call would be to use pidfd_open, which is available in Linux 5.3 or later.

What is the minimal kernel version that we need to support?

@edigiacomo
Copy link
Member

We must surely support Rocky Linux 8 which is distributed with kernel version 4.18, but it's possible that we need to support Centos 7 too (Linux 3.10).

@dcesari
Copy link
Member

dcesari commented Apr 27, 2023

There is still a machine with centos 7 and arkimet around, but it is acceptable to freeze it, so that is not a problem, however Rocky Linux 8 should be supported at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants