diff --git a/core/debugger/remote_debugger_peer.cpp b/core/debugger/remote_debugger_peer.cpp index 9dca47a0b4f2..1f93c849757f 100644 --- a/core/debugger/remote_debugger_peer.cpp +++ b/core/debugger/remote_debugger_peer.cpp @@ -45,7 +45,7 @@ bool RemoteDebuggerPeerTCP::has_message() { Array RemoteDebuggerPeerTCP::get_message() { MutexLock lock(mutex); ERR_FAIL_COND_V(!has_message(), Array()); - Array out = in_queue.front()->get(); + Array out = in_queue.get_front(); in_queue.pop_front(); return out; } @@ -100,7 +100,7 @@ void RemoteDebuggerPeerTCP::_write_out() { break; // Nothing left to send } mutex.lock(); - Variant var = out_queue.front()->get(); + Variant var = out_queue.get_front(); out_queue.pop_front(); mutex.unlock(); int size = 0; diff --git a/core/io/udp_server.cpp b/core/io/udp_server.cpp index 75ba784dbd16..d4e9913ea745 100644 --- a/core/io/udp_server.cpp +++ b/core/io/udp_server.cpp @@ -161,7 +161,7 @@ Ref UDPServer::take_connection() { return conn; } - Peer peer = pending.front()->get(); + Peer peer = pending.get_front(); pending.pop_front(); peers.push_back(peer); return peer.peer; diff --git a/editor/debugger/editor_debugger_tree.cpp b/editor/debugger/editor_debugger_tree.cpp index a90084265141..9b98eb81f5c6 100644 --- a/editor/debugger/editor_debugger_tree.cpp +++ b/editor/debugger/editor_debugger_tree.cpp @@ -156,7 +156,7 @@ void EditorDebuggerTree::update_scene_tree(const SceneDebuggerTree *p_tree, int for (const SceneDebuggerTree::RemoteNode &node : p_tree->nodes) { TreeItem *parent = nullptr; if (parents.size()) { // Find last parent. - Pair &p = parents.front()->get(); + Pair &p = parents.get_front(); parent = p.first; if (!(--p.second)) { // If no child left, remove it. parents.pop_front(); diff --git a/editor/editor_inspector.cpp b/editor/editor_inspector.cpp index 21f67772ea24..10f91dbb8e9d 100644 --- a/editor/editor_inspector.cpp +++ b/editor/editor_inspector.cpp @@ -2605,12 +2605,12 @@ EditorProperty *EditorInspector::instantiate_property_editor(Object *p_object, c memdelete(E->get().property_editor); } - EditorProperty *prop = Object::cast_to(inspector_plugins[i]->added_editors.front()->get().property_editor); + EditorProperty *prop = Object::cast_to(inspector_plugins[i]->added_editors.get_front().property_editor); if (prop) { inspector_plugins[i]->added_editors.clear(); return prop; } else { - memdelete(inspector_plugins[i]->added_editors.front()->get().property_editor); + memdelete(inspector_plugins[i]->added_editors.get_front().property_editor); inspector_plugins[i]->added_editors.clear(); } } diff --git a/editor/export/project_export.cpp b/editor/export/project_export.cpp index f9137082d70c..c1d8e8ac6130 100644 --- a/editor/export/project_export.cpp +++ b/editor/export/project_export.cpp @@ -1247,7 +1247,7 @@ void ProjectExportDialog::_export_project() { export_project->set_current_path(current->get_export_path()); } else { if (extension_list.size() >= 1) { - export_project->set_current_file(default_filename + "." + extension_list.front()->get()); + export_project->set_current_file(default_filename + "." + extension_list.get_front()); } else { export_project->set_current_file(default_filename); } diff --git a/editor/import/3d/resource_importer_scene.cpp b/editor/import/3d/resource_importer_scene.cpp index cb348f713c12..57f12d7885ed 100644 --- a/editor/import/3d/resource_importer_scene.cpp +++ b/editor/import/3d/resource_importer_scene.cpp @@ -1434,7 +1434,7 @@ Node *ResourceImporterScene::_post_fix_node(Node *p_node, Node *p_root, HashMap< List anim_list; anim_player->get_animation_list(&anim_list); if (anim_list.size() == 1) { - selected_animation_name = anim_list.front()->get(); + selected_animation_name = anim_list.get_front(); } rest_animation = anim_player->get_animation(selected_animation_name); if (rest_animation.is_valid()) { @@ -1450,7 +1450,7 @@ Node *ResourceImporterScene::_post_fix_node(Node *p_node, Node *p_root, HashMap< List anim_list; library->get_animation_list(&anim_list); if (anim_list.size() == 1) { - selected_animation_name = String(anim_list.front()->get()); + selected_animation_name = String(anim_list.get_front()); } rest_animation = library->get_animation(selected_animation_name); } @@ -2250,7 +2250,7 @@ bool ResourceImporterScene::get_internal_option_visibility(InternalImportCategor List anim_list; library->get_animation_list(&anim_list); if (anim_list.size() == 1) { - selected_animation_name = String(anim_list.front()->get()); + selected_animation_name = String(anim_list.get_front()); } if (library->has_animation(selected_animation_name)) { anim = library->get_animation(selected_animation_name); diff --git a/editor/import/3d/scene_import_settings.cpp b/editor/import/3d/scene_import_settings.cpp index 011d0135b448..615a0a3a1466 100644 --- a/editor/import/3d/scene_import_settings.cpp +++ b/editor/import/3d/scene_import_settings.cpp @@ -150,7 +150,7 @@ class SceneImportSettingsData : public Object { List anim_names; library->get_animation_list(&anim_names); if (anim_names.size() == 1) { - (*settings)["rest_pose/selected_animation"] = String(anim_names.front()->get()); + (*settings)["rest_pose/selected_animation"] = String(anim_names.get_front()); } for (StringName anim_name : anim_names) { hint_string += "," + anim_name; // Include preceding, as a catch-all. diff --git a/editor/plugins/canvas_item_editor_plugin.cpp b/editor/plugins/canvas_item_editor_plugin.cpp index e9a796dae723..25d893b84141 100644 --- a/editor/plugins/canvas_item_editor_plugin.cpp +++ b/editor/plugins/canvas_item_editor_plugin.cpp @@ -457,8 +457,8 @@ Point2 CanvasItemEditor::snap_point(Point2 p_target, unsigned int p_modes, unsig Point2 offset = grid_offset; if (snap_relative) { List selection = _get_edited_canvas_items(); - if (selection.size() == 1 && Object::cast_to(selection.front()->get())) { - offset = Object::cast_to(selection.front()->get())->get_global_position(); + if (selection.size() == 1 && Object::cast_to(selection.get_front())) { + offset = Object::cast_to(selection.get_front())->get_global_position(); } else if (selection.size() > 0) { offset = _get_encompassing_rect_from_list(selection).position; } @@ -760,7 +760,7 @@ bool CanvasItemEditor::_select_click_on_item(CanvasItem *item, Point2 p_click_po still_selected = false; if (editor_selection->get_selected_node_list().size() == 1) { - EditorNode::get_singleton()->push_item(editor_selection->get_selected_node_list().front()->get()); + EditorNode::get_singleton()->push_item(editor_selection->get_selected_node_list().get_front()); } } else { // Add the item to the selection @@ -1381,7 +1381,7 @@ bool CanvasItemEditor::_gui_input_pivot(const Ref &p_event) { drag_from = transform.affine_inverse().xform(event_pos); Vector2 new_pos; if (drag_selection.size() == 1) { - new_pos = snap_point(drag_from, SNAP_NODE_SIDES | SNAP_NODE_CENTER | SNAP_NODE_ANCHORS | SNAP_OTHER_NODES | SNAP_GRID | SNAP_PIXEL, 0, drag_selection.front()->get()); + new_pos = snap_point(drag_from, SNAP_NODE_SIDES | SNAP_NODE_CENTER | SNAP_NODE_ANCHORS | SNAP_OTHER_NODES | SNAP_GRID | SNAP_PIXEL, 0, drag_selection.get_front()); } else { new_pos = snap_point(drag_from, SNAP_OTHER_NODES | SNAP_GRID | SNAP_PIXEL, 0, nullptr, drag_selection); } @@ -1402,7 +1402,7 @@ bool CanvasItemEditor::_gui_input_pivot(const Ref &p_event) { _restore_canvas_item_state(drag_selection); Vector2 new_pos; if (drag_selection.size() == 1) { - new_pos = snap_point(drag_to, SNAP_NODE_SIDES | SNAP_NODE_CENTER | SNAP_NODE_ANCHORS | SNAP_OTHER_NODES | SNAP_GRID | SNAP_PIXEL, 0, drag_selection.front()->get()); + new_pos = snap_point(drag_to, SNAP_NODE_SIDES | SNAP_NODE_CENTER | SNAP_NODE_ANCHORS | SNAP_OTHER_NODES | SNAP_GRID | SNAP_PIXEL, 0, drag_selection.get_front()); } else { new_pos = snap_point(drag_to, SNAP_OTHER_NODES | SNAP_GRID | SNAP_PIXEL); } @@ -1420,9 +1420,9 @@ bool CanvasItemEditor::_gui_input_pivot(const Ref &p_event) { drag_selection, vformat( TTR("Set CanvasItem \"%s\" Pivot Offset to (%d, %d)"), - drag_selection.front()->get()->get_name(), - drag_selection.front()->get()->_edit_get_pivot().x, - drag_selection.front()->get()->_edit_get_pivot().y)); + drag_selection.get_front()->get_name(), + drag_selection.get_front()->_edit_get_pivot().x, + drag_selection.get_front()->_edit_get_pivot().y)); _reset_drag(); return true; } @@ -1474,7 +1474,7 @@ bool CanvasItemEditor::_gui_input_rotate(const Ref &p_event) { if (drag_selection.size() > 0) { drag_type = DRAG_ROTATE; drag_from = transform.affine_inverse().xform(b->get_position()); - CanvasItem *ci = drag_selection.front()->get(); + CanvasItem *ci = drag_selection.get_front(); if (!Math::is_inf(temp_pivot.x) || !Math::is_inf(temp_pivot.y)) { drag_rotation_center = temp_pivot; } else if (ci->_edit_use_pivot()) { @@ -1528,8 +1528,8 @@ bool CanvasItemEditor::_gui_input_rotate(const Ref &p_event) { _commit_canvas_item_state( drag_selection, vformat(TTR("Rotate CanvasItem \"%s\" to %d degrees"), - drag_selection.front()->get()->get_name(), - Math::rad_to_deg(drag_selection.front()->get()->_edit_get_rotation())), + drag_selection.get_front()->get_name(), + Math::rad_to_deg(drag_selection.get_front()->_edit_get_rotation())), true); } @@ -1559,7 +1559,7 @@ bool CanvasItemEditor::_gui_input_open_scene_on_double_click(const Refget_button_index() == MouseButton::LEFT && b->is_pressed() && b->is_double_click() && tool == TOOL_SELECT) { List selection = _get_edited_canvas_items(); if (selection.size() == 1) { - CanvasItem *ci = selection.front()->get(); + CanvasItem *ci = selection.get_front(); if (!ci->get_scene_file_path().is_empty() && ci != EditorNode::get_singleton()->get_edited_scene()) { EditorNode::get_singleton()->open_request(ci->get_scene_file_path()); return true; @@ -1578,7 +1578,7 @@ bool CanvasItemEditor::_gui_input_anchors(const Ref &p_event) { if (b.is_valid() && b->get_button_index() == MouseButton::LEFT && b->is_pressed() && tool == TOOL_SELECT) { List selection = _get_edited_canvas_items(); if (selection.size() == 1) { - Control *control = Object::cast_to(selection.front()->get()); + Control *control = Object::cast_to(selection.get_front()); if (control && _is_node_movable(control)) { Vector2 anchor_pos[4]; anchor_pos[0] = Vector2(control->get_anchor(SIDE_LEFT), control->get_anchor(SIDE_TOP)); @@ -1627,7 +1627,7 @@ bool CanvasItemEditor::_gui_input_anchors(const Ref &p_event) { // Drag the anchor if (m.is_valid()) { _restore_canvas_item_state(drag_selection); - Control *control = Object::cast_to(drag_selection.front()->get()); + Control *control = Object::cast_to(drag_selection.get_front()); drag_to = transform.affine_inverse().xform(m->get_position()); @@ -1698,7 +1698,7 @@ bool CanvasItemEditor::_gui_input_anchors(const Ref &p_event) { if (drag_selection.size() >= 1 && b.is_valid() && b->get_button_index() == MouseButton::LEFT && !b->is_pressed()) { _commit_canvas_item_state( drag_selection, - vformat(TTR("Move CanvasItem \"%s\" Anchor"), drag_selection.front()->get()->get_name())); + vformat(TTR("Move CanvasItem \"%s\" Anchor"), drag_selection.get_front()->get_name())); snap_target[0] = SNAP_TARGET_NONE; snap_target[1] = SNAP_TARGET_NONE; _reset_drag(); @@ -1728,7 +1728,7 @@ bool CanvasItemEditor::_gui_input_resize(const Ref &p_event) { if (b.is_valid() && b->get_button_index() == MouseButton::LEFT && b->is_pressed() && tool == TOOL_SELECT) { List selection = _get_edited_canvas_items(); if (selection.size() == 1) { - CanvasItem *ci = selection.front()->get(); + CanvasItem *ci = selection.get_front(); if (ci->_edit_use_rect() && _is_node_movable(ci)) { Rect2 rect = ci->_edit_get_rect(); Transform2D xform = transform * ci->get_global_transform_with_canvas(); @@ -1789,7 +1789,7 @@ bool CanvasItemEditor::_gui_input_resize(const Ref &p_event) { drag_type == DRAG_TOP_LEFT || drag_type == DRAG_TOP_RIGHT || drag_type == DRAG_BOTTOM_LEFT || drag_type == DRAG_BOTTOM_RIGHT) { // Resize the node if (m.is_valid()) { - CanvasItem *ci = drag_selection.front()->get(); + CanvasItem *ci = drag_selection.get_front(); CanvasItemEditorSelectedItem *se = editor_selection->get_node_editor_data(ci); //Reset state ci->_edit_set_state(se->undo_state); @@ -1874,7 +1874,7 @@ bool CanvasItemEditor::_gui_input_resize(const Ref &p_event) { // Confirm resize if (drag_selection.size() >= 1 && b.is_valid() && b->get_button_index() == MouseButton::LEFT && !b->is_pressed()) { - const Node2D *node2d = Object::cast_to(drag_selection.front()->get()); + const Node2D *node2d = Object::cast_to(drag_selection.get_front()); if (node2d) { // Extends from Node2D. // Node2D doesn't have an actual stored rect size, unlike Controls. @@ -1882,9 +1882,9 @@ bool CanvasItemEditor::_gui_input_resize(const Ref &p_event) { drag_selection, vformat( TTR("Scale Node2D \"%s\" to (%s, %s)"), - drag_selection.front()->get()->get_name(), - Math::snapped(drag_selection.front()->get()->_edit_get_scale().x, 0.01), - Math::snapped(drag_selection.front()->get()->_edit_get_scale().y, 0.01)), + drag_selection.get_front()->get_name(), + Math::snapped(drag_selection.get_front()->_edit_get_scale().x, 0.01), + Math::snapped(drag_selection.get_front()->_edit_get_scale().y, 0.01)), true); } else { // Extends from Control. @@ -1892,9 +1892,9 @@ bool CanvasItemEditor::_gui_input_resize(const Ref &p_event) { drag_selection, vformat( TTR("Resize Control \"%s\" to (%d, %d)"), - drag_selection.front()->get()->get_name(), - drag_selection.front()->get()->_edit_get_rect().size.x, - drag_selection.front()->get()->_edit_get_rect().size.y), + drag_selection.get_front()->get_name(), + drag_selection.get_front()->_edit_get_rect().size.x, + drag_selection.get_front()->_edit_get_rect().size.y), true); } @@ -1932,7 +1932,7 @@ bool CanvasItemEditor::_gui_input_scale(const Ref &p_event) { bool has_locked_items = false; List selection = _get_edited_canvas_items(false, true, &has_locked_items); if (selection.size() == 1) { - CanvasItem *ci = selection.front()->get(); + CanvasItem *ci = selection.get_front(); if (_is_node_movable(ci)) { Transform2D xform = transform * ci->get_global_transform_with_canvas(); @@ -1972,7 +1972,7 @@ bool CanvasItemEditor::_gui_input_scale(const Ref &p_event) { // Resize the node if (m.is_valid()) { _restore_canvas_item_state(drag_selection); - CanvasItem *ci = drag_selection.front()->get(); + CanvasItem *ci = drag_selection.get_front(); drag_to = transform.affine_inverse().xform(m->get_position()); @@ -2040,9 +2040,9 @@ bool CanvasItemEditor::_gui_input_scale(const Ref &p_event) { _commit_canvas_item_state( drag_selection, vformat(TTR("Scale CanvasItem \"%s\" to (%s, %s)"), - drag_selection.front()->get()->get_name(), - Math::snapped(drag_selection.front()->get()->_edit_get_scale().x, 0.01), - Math::snapped(drag_selection.front()->get()->_edit_get_scale().y, 0.01)), + drag_selection.get_front()->get_name(), + Math::snapped(drag_selection.get_front()->_edit_get_scale().x, 0.01), + Math::snapped(drag_selection.get_front()->_edit_get_scale().y, 0.01)), true); } if (key_auto_insert_button->is_pressed()) { @@ -2087,7 +2087,7 @@ bool CanvasItemEditor::_gui_input_move(const Ref &p_event) { drag_type = DRAG_MOVE; - CanvasItem *ci = selection.front()->get(); + CanvasItem *ci = selection.get_front(); Transform2D parent_xform = ci->get_global_transform_with_canvas() * ci->get_transform().affine_inverse(); Transform2D unscaled_transform = (transform * parent_xform * ci->_edit_get_transform()).orthonormalized(); Transform2D simple_xform = viewport->get_transform() * unscaled_transform; @@ -2126,8 +2126,8 @@ bool CanvasItemEditor::_gui_input_move(const Ref &p_event) { drag_to = transform.affine_inverse().xform(m->get_position()); Point2 previous_pos; if (drag_selection.size() == 1) { - Transform2D parent_xform = drag_selection.front()->get()->get_global_transform_with_canvas() * drag_selection.front()->get()->get_transform().affine_inverse(); - previous_pos = parent_xform.xform(drag_selection.front()->get()->_edit_get_position()); + Transform2D parent_xform = drag_selection.get_front()->get_global_transform_with_canvas() * drag_selection.get_front()->get_transform().affine_inverse(); + previous_pos = parent_xform.xform(drag_selection.get_front()->_edit_get_position()); } else { previous_pos = _get_encompassing_rect_from_list(drag_selection).position; } @@ -2178,9 +2178,9 @@ bool CanvasItemEditor::_gui_input_move(const Ref &p_event) { drag_selection, vformat( TTR("Move CanvasItem \"%s\" to (%d, %d)"), - drag_selection.front()->get()->get_name(), - drag_selection.front()->get()->_edit_get_position().x, - drag_selection.front()->get()->_edit_get_position().y), + drag_selection.get_front()->get_name(), + drag_selection.get_front()->_edit_get_position().x, + drag_selection.get_front()->_edit_get_position().y), true); } } @@ -2256,15 +2256,15 @@ bool CanvasItemEditor::_gui_input_move(const Ref &p_event) { Point2 previous_pos; if (drag_selection.size() == 1) { - Transform2D xform = drag_selection.front()->get()->get_global_transform_with_canvas() * drag_selection.front()->get()->get_transform().affine_inverse(); - previous_pos = xform.xform(drag_selection.front()->get()->_edit_get_position()); + Transform2D xform = drag_selection.get_front()->get_global_transform_with_canvas() * drag_selection.get_front()->get_transform().affine_inverse(); + previous_pos = xform.xform(drag_selection.get_front()->_edit_get_position()); } else { previous_pos = _get_encompassing_rect_from_list(drag_selection).position; } Point2 new_pos; if (drag_selection.size() == 1) { - Node2D *node_2d = Object::cast_to(drag_selection.front()->get()); + Node2D *node_2d = Object::cast_to(drag_selection.get_front()); if (node_2d && move_local_base_rotated) { Transform2D m2; m2.rotate(node_2d->get_rotation()); @@ -2302,9 +2302,9 @@ bool CanvasItemEditor::_gui_input_move(const Ref &p_event) { _commit_canvas_item_state( drag_selection, vformat(TTR("Move CanvasItem \"%s\" to (%d, %d)"), - drag_selection.front()->get()->get_name(), - drag_selection.front()->get()->_edit_get_position().x, - drag_selection.front()->get()->_edit_get_position().y), + drag_selection.get_front()->get_name(), + drag_selection.get_front()->_edit_get_position().x, + drag_selection.get_front()->_edit_get_position().y), true); } _reset_drag(); @@ -2516,7 +2516,7 @@ bool CanvasItemEditor::_gui_input_select(const Ref &p_event) { _find_canvas_items_in_rect(Rect2(bsfrom, bsto - bsfrom), scene, &selitems); if (selitems.size() == 1 && editor_selection->get_selected_node_list().is_empty()) { - EditorNode::get_singleton()->push_item(selitems.front()->get()); + EditorNode::get_singleton()->push_item(selitems.get_front()); } for (CanvasItem *E : selitems) { editor_selection->add_node(E); @@ -2770,7 +2770,7 @@ Control::CursorShape CanvasItemEditor::get_cursor_shape(const Point2 &p_pos) con List selection = _get_edited_canvas_items(); if (selection.size() == 1) { - const double angle = Math::fposmod((double)selection.front()->get()->get_global_transform_with_canvas().get_rotation(), Math_PI); + const double angle = Math::fposmod((double)selection.get_front()->get_global_transform_with_canvas().get_rotation(), Math_PI); if (angle > Math_PI * 7.0 / 8.0) { rotation_array_index = 0; } else if (angle > Math_PI * 5.0 / 8.0) { @@ -6233,7 +6233,7 @@ void CanvasItemEditorViewport::drop_data(const Point2 &p_point, const Variant &p List selected_nodes = EditorNode::get_singleton()->get_editor_selection()->get_selected_node_list(); Node *root_node = EditorNode::get_singleton()->get_edited_scene(); if (selected_nodes.size() > 0) { - Node *selected_node = selected_nodes.front()->get(); + Node *selected_node = selected_nodes.get_front(); if (is_alt) { target_node = root_node; } else if (is_shift) { diff --git a/editor/plugins/node_3d_editor_plugin.cpp b/editor/plugins/node_3d_editor_plugin.cpp index 0df0274495f3..c839f1767baf 100644 --- a/editor/plugins/node_3d_editor_plugin.cpp +++ b/editor/plugins/node_3d_editor_plugin.cpp @@ -788,7 +788,7 @@ void Node3DEditorViewport::_select_clicked(bool p_allow_locked) { } if (editor_selection->get_selected_node_list().size() == 1) { - EditorNode::get_singleton()->edit_node(editor_selection->get_selected_node_list().front()->get()); + EditorNode::get_singleton()->edit_node(editor_selection->get_selected_node_list().get_front()); } } } @@ -1119,7 +1119,7 @@ void Node3DEditorViewport::_select_region() { } if (editor_selection->get_selected_node_list().size() == 1) { - EditorNode::get_singleton()->edit_node(editor_selection->get_selected_node_list().front()->get()); + EditorNode::get_singleton()->edit_node(editor_selection->get_selected_node_list().get_front()); } } @@ -4900,7 +4900,7 @@ void Node3DEditorViewport::drop_data_fw(const Point2 &p_point, const Variant &p_ List selected_nodes = EditorNode::get_singleton()->get_editor_selection()->get_selected_node_list(); Node *root_node = EditorNode::get_singleton()->get_edited_scene(); if (selected_nodes.size() > 0) { - Node *selected_node = selected_nodes.front()->get(); + Node *selected_node = selected_nodes.get_front(); if (is_alt) { target_node = root_node; } else if (is_shift) { diff --git a/editor/plugins/script_text_editor.cpp b/editor/plugins/script_text_editor.cpp index b45b30b52ec1..22d9f635e8da 100644 --- a/editor/plugins/script_text_editor.cpp +++ b/editor/plugins/script_text_editor.cpp @@ -542,9 +542,9 @@ void ScriptTextEditor::_validate_script() { if (errors.size() > 0) { // TRANSLATORS: Script error pointing to a line and column number. - String error_text = vformat(TTR("Error at (%d, %d):"), errors.front()->get().line, errors.front()->get().column) + " " + errors.front()->get().message; + String error_text = vformat(TTR("Error at (%d, %d):"), errors.get_front().line, errors.get_front().column) + " " + errors.get_front().message; code_editor->set_error(error_text); - code_editor->set_error_pos(errors.front()->get().line - 1, errors.front()->get().column - 1); + code_editor->set_error_pos(errors.get_front().line - 1, errors.get_front().column - 1); } script_is_valid = false; } else { diff --git a/editor/plugins/sprite_frames_editor_plugin.cpp b/editor/plugins/sprite_frames_editor_plugin.cpp index 168a3b3ac2b1..be2586c34ba4 100644 --- a/editor/plugins/sprite_frames_editor_plugin.cpp +++ b/editor/plugins/sprite_frames_editor_plugin.cpp @@ -1766,7 +1766,7 @@ void SpriteFramesEditor::_fetch_sprite_node() { Node *selected = nullptr; EditorSelection *editor_selection = EditorNode::get_singleton()->get_editor_selection(); if (editor_selection->get_selected_node_list().size() == 1) { - selected = editor_selection->get_selected_node_list().front()->get(); + selected = editor_selection->get_selected_node_list().get_front(); } bool show_node_edit = false; diff --git a/editor/plugins/visual_shader_editor_plugin.cpp b/editor/plugins/visual_shader_editor_plugin.cpp index a5df9edcf027..417b98bdb78e 100644 --- a/editor/plugins/visual_shader_editor_plugin.cpp +++ b/editor/plugins/visual_shader_editor_plugin.cpp @@ -4240,7 +4240,7 @@ void VisualShaderEditor::_handle_node_drop_on_connection() { return; } - int selected_node_id = drag_buffer.front()->get().node; + int selected_node_id = drag_buffer.get_front().node; VisualShader::Type shader_type = get_current_shader_type(); Ref selected_vsnode = visual_shader->get_node(shader_type, selected_node_id); diff --git a/editor/scene_tree_dock.cpp b/editor/scene_tree_dock.cpp index 11aa28283385..a163fc17bf36 100644 --- a/editor/scene_tree_dock.cpp +++ b/editor/scene_tree_dock.cpp @@ -1081,7 +1081,7 @@ void SceneTreeDock::_tool_selected(int p_tool, bool p_confirm_override) { msg = vformat(any_children ? TTR("Delete %d nodes and any children?") : TTR("Delete %d nodes?"), remove_list.size()); } else { if (!p_confirm_override) { - Node *node = remove_list.front()->get(); + Node *node = remove_list.get_front(); if (node == editor_data->get_edited_scene_root()) { msg = vformat(TTR("Delete the root node \"%s\"?"), node->get_name()); } else if (node->get_scene_file_path().is_empty() && node->get_child_count() > 0) { @@ -3528,7 +3528,7 @@ void SceneTreeDock::_files_dropped(const Vector &p_files, NodePath p_to, return; } if (!valid_properties.is_empty()) { - _perform_property_drop(node, valid_properties.front()->get(), ResourceLoader::load(res_path)); + _perform_property_drop(node, valid_properties.get_front(), ResourceLoader::load(res_path)); return; } } @@ -3710,7 +3710,7 @@ void SceneTreeDock::_tree_rmb(const Vector2 &p_menu_pos) { bool existing_script_removable = true; bool allow_attach_new_script = true; if (selection.size() == 1) { - Node *selected = selection.front()->get(); + Node *selected = selection.get_front(); if (profile_allow_editing) { subresources.clear(); @@ -3847,17 +3847,17 @@ void SceneTreeDock::_tree_rmb(const Vector2 &p_menu_pos) { if (menu->get_item_index(TOOL_COPY_NODE_PATH) == -1) { menu->add_separator(); } - Node *node = full_selection.front()->get(); + Node *node = full_selection.get_front(); menu->add_icon_shortcut(get_editor_theme_icon(SNAME("SceneUniqueName")), ED_GET_SHORTCUT("scene_tree/toggle_unique_name"), TOOL_TOGGLE_SCENE_UNIQUE_NAME); menu->set_item_text(menu->get_item_index(TOOL_TOGGLE_SCENE_UNIQUE_NAME), node->is_unique_name_in_owner() ? TTR("Revoke Unique Name") : TTR("Access as Unique Name")); } } if (selection.size() == 1) { - bool is_external = (!selection.front()->get()->get_scene_file_path().is_empty()); + bool is_external = (!selection.get_front()->get_scene_file_path().is_empty()); if (is_external) { - bool is_inherited = selection.front()->get()->get_scene_inherited_state().is_valid(); - bool is_top_level = selection.front()->get()->get_owner() == nullptr; + bool is_inherited = selection.get_front()->get_scene_inherited_state().is_valid(); + bool is_top_level = selection.get_front()->get_owner() == nullptr; if (is_inherited && is_top_level) { menu->add_separator(); if (profile_allow_editing) { @@ -3866,8 +3866,8 @@ void SceneTreeDock::_tree_rmb(const Vector2 &p_menu_pos) { menu->add_icon_item(get_editor_theme_icon(SNAME("Load")), TTR("Open in Editor"), TOOL_SCENE_OPEN_INHERITED); } else if (!is_top_level) { menu->add_separator(); - bool editable = EditorNode::get_singleton()->get_edited_scene()->is_editable_instance(selection.front()->get()); - bool placeholder = selection.front()->get()->get_scene_instance_load_placeholder(); + bool editable = EditorNode::get_singleton()->get_edited_scene()->is_editable_instance(selection.get_front()); + bool placeholder = selection.get_front()->get_scene_instance_load_placeholder(); if (profile_allow_editing) { menu->add_check_item(TTR("Editable Children"), TOOL_SCENE_EDITABLE_CHILDREN); menu->set_item_shortcut(-1, ED_GET_SHORTCUT("scene_tree/toggle_editable_children")); @@ -3893,7 +3893,7 @@ void SceneTreeDock::_tree_rmb(const Vector2 &p_menu_pos) { #endif // MODULE_REGEX_ENABLED menu->add_separator(); - if (full_selection.size() == 1 && !selection.front()->get()->get_scene_file_path().is_empty()) { + if (full_selection.size() == 1 && !selection.get_front()->get_scene_file_path().is_empty()) { menu->add_icon_shortcut(get_editor_theme_icon(SNAME("ShowInFileSystem")), ED_GET_SHORTCUT("scene_tree/show_in_file_system"), TOOL_SHOW_IN_FILE_SYSTEM); } diff --git a/modules/enet/enet_multiplayer_peer.cpp b/modules/enet/enet_multiplayer_peer.cpp index 6f87a398c764..5f88c5646b0f 100644 --- a/modules/enet/enet_multiplayer_peer.cpp +++ b/modules/enet/enet_multiplayer_peer.cpp @@ -124,9 +124,9 @@ Error ENetMultiplayerPeer::add_mesh_peer(int p_id, Ref p_host) { ERR_FAIL_COND_V_MSG(active_mode != MODE_MESH, ERR_UNCONFIGURED, "The multiplayer instance is not configured as a mesh. Call 'create_mesh' first."); List> host_peers; p_host->get_peers(host_peers); - ERR_FAIL_COND_V_MSG(host_peers.size() != 1 || host_peers.front()->get()->get_state() != ENetPacketPeer::STATE_CONNECTED, ERR_INVALID_PARAMETER, "The provided host must have exactly one peer in the connected state."); + ERR_FAIL_COND_V_MSG(host_peers.size() != 1 || host_peers.get_front()->get_state() != ENetPacketPeer::STATE_CONNECTED, ERR_INVALID_PARAMETER, "The provided host must have exactly one peer in the connected state."); hosts[p_id] = p_host; - peers[p_id] = host_peers.front()->get(); + peers[p_id] = host_peers.get_front(); emit_signal(SNAME("peer_connected"), p_id); return OK; } diff --git a/modules/gdscript/language_server/gdscript_extend_parser.cpp b/modules/gdscript/language_server/gdscript_extend_parser.cpp index 2a3db4f508d5..7f5f5d66fe04 100644 --- a/modules/gdscript/language_server/gdscript_extend_parser.cpp +++ b/modules/gdscript/language_server/gdscript_extend_parser.cpp @@ -510,7 +510,7 @@ void ExtendGDScriptParser::parse_function_symbol(const GDScriptParser::FunctionN node_stack.push_back(p_func->body); while (!node_stack.is_empty()) { - GDScriptParser::Node *node = node_stack.front()->get(); + GDScriptParser::Node *node = node_stack.get_front(); node_stack.pop_front(); switch (node->type) { diff --git a/modules/gdscript/language_server/gdscript_workspace.cpp b/modules/gdscript/language_server/gdscript_workspace.cpp index 09defdf8cd76..fb5ad0de23dc 100644 --- a/modules/gdscript/language_server/gdscript_workspace.cpp +++ b/modules/gdscript/language_server/gdscript_workspace.cpp @@ -223,7 +223,7 @@ void GDScriptWorkspace::reload_all_workspace_scripts() { HashMap::Iterator S = parse_results.find(path); String err_msg = "Failed parse script " + path; if (S) { - err_msg += "\n" + S->value->get_errors().front()->get().message; + err_msg += "\n" + S->value->get_errors().get_front().message; } ERR_CONTINUE_MSG(err != OK, err_msg); } diff --git a/modules/gdscript/tests/gdscript_test_runner.cpp b/modules/gdscript/tests/gdscript_test_runner.cpp index 025fcbd32a35..1ec07b3edd82 100644 --- a/modules/gdscript/tests/gdscript_test_runner.cpp +++ b/modules/gdscript/tests/gdscript_test_runner.cpp @@ -572,7 +572,7 @@ GDScriptTest::TestResult GDScriptTest::execute_test_code(bool p_is_generating) { const List &errors = parser.get_errors(); if (!errors.is_empty()) { // Only the first error since the following might be cascading. - result.output += errors.front()->get().message + "\n"; // TODO: line, column? + result.output += errors.get_front().message + "\n"; // TODO: line, column? } if (!p_is_generating) { result.passed = check_output(result.output); @@ -591,7 +591,7 @@ GDScriptTest::TestResult GDScriptTest::execute_test_code(bool p_is_generating) { const List &errors = parser.get_errors(); if (!errors.is_empty()) { // Only the first error since the following might be cascading. - result.output += errors.front()->get().message + "\n"; // TODO: line, column? + result.output += errors.get_front().message + "\n"; // TODO: line, column? } if (!p_is_generating) { result.passed = check_output(result.output); diff --git a/modules/mono/editor/bindings_generator.cpp b/modules/mono/editor/bindings_generator.cpp index e97229c62155..2b4b2c328dbb 100644 --- a/modules/mono/editor/bindings_generator.cpp +++ b/modules/mono/editor/bindings_generator.cpp @@ -2850,8 +2850,8 @@ Error BindingsGenerator::_generate_cs_method(const BindingsGenerator::TypeInterf StringBuilder default_args_doc; - // Retrieve information from the arguments - const ArgumentInterface &first = p_imethod.arguments.front()->get(); + // Retrieve information from the arguments. + const List::Element *first = p_imethod.arguments.front(); for (const ArgumentInterface &iarg : p_imethod.arguments) { const TypeInterface *arg_type = _get_type_or_singleton_or_null(iarg.type); ERR_FAIL_NULL_V_MSG(arg_type, ERR_BUG, "Argument type '" + iarg.type.cname + "' was not found."); @@ -2877,7 +2877,7 @@ Error BindingsGenerator::_generate_cs_method(const BindingsGenerator::TypeInterf // Add the current arguments to the signature // If the argument has a default value which is not a constant, we will make it Nullable { - if (&iarg != &first) { + if (&iarg != &first->get()) { arguments_sig += ", "; } @@ -3109,8 +3109,8 @@ Error BindingsGenerator::_generate_cs_method(const BindingsGenerator::TypeInterf Error BindingsGenerator::_generate_cs_signal(const BindingsGenerator::TypeInterface &p_itype, const BindingsGenerator::SignalInterface &p_isignal, StringBuilder &p_output) { String arguments_sig; - // Retrieve information from the arguments - const ArgumentInterface &first = p_isignal.arguments.front()->get(); + // Retrieve information from the arguments. + const List::Element *first = p_isignal.arguments.front(); for (const ArgumentInterface &iarg : p_isignal.arguments) { const TypeInterface *arg_type = _get_type_or_singleton_or_null(iarg.type); ERR_FAIL_NULL_V_MSG(arg_type, ERR_BUG, "Argument type '" + iarg.type.cname + "' was not found."); @@ -3126,7 +3126,7 @@ Error BindingsGenerator::_generate_cs_signal(const BindingsGenerator::TypeInterf // Add the current arguments to the signature - if (&iarg != &first) { + if (&iarg != &first->get()) { arguments_sig += ", "; } diff --git a/modules/multiplayer/scene_replication_interface.cpp b/modules/multiplayer/scene_replication_interface.cpp index edc66c876c31..1a7ca1bc6260 100644 --- a/modules/multiplayer/scene_replication_interface.cpp +++ b/modules/multiplayer/scene_replication_interface.cpp @@ -242,7 +242,7 @@ Error SceneReplicationInterface::on_replication_start(Object *p_obj, Variant p_c // Try to apply synchronizer Net ID ERR_FAIL_COND_V_MSG(pending_sync_net_ids.is_empty(), ERR_INVALID_DATA, vformat("The MultiplayerSynchronizer at path \"%s\" is unable to process the pending spawn since it has no network ID. This might happen when changing the multiplayer authority during the \"_ready\" callback. Make sure to only change the authority of multiplayer synchronizers during \"_enter_tree\" or the \"_spawn_custom\" callback of their multiplayer spawner.", sync->get_path())); ERR_FAIL_COND_V(!peers_info.has(pending_spawn_remote), ERR_INVALID_DATA); - uint32_t net_id = pending_sync_net_ids.front()->get(); + uint32_t net_id = pending_sync_net_ids.get_front(); pending_sync_net_ids.pop_front(); peers_info[pending_spawn_remote].recv_sync_ids[net_id] = sync->get_instance_id(); sync->set_net_id(net_id); diff --git a/modules/websocket/remote_debugger_peer_websocket.cpp b/modules/websocket/remote_debugger_peer_websocket.cpp index a40ea0205e68..1b365469ff7e 100644 --- a/modules/websocket/remote_debugger_peer_websocket.cpp +++ b/modules/websocket/remote_debugger_peer_websocket.cpp @@ -74,7 +74,7 @@ void RemoteDebuggerPeerWebSocket::poll() { } while (ws_peer->get_ready_state() == WebSocketPeer::STATE_OPEN && out_queue.size() > 0) { - Array var = out_queue.front()->get(); + Array var = out_queue.get_front(); Error err = ws_peer->put_var(var); ERR_BREAK(err != OK); // Peer buffer full? out_queue.pop_front(); @@ -92,7 +92,7 @@ bool RemoteDebuggerPeerWebSocket::has_message() { Array RemoteDebuggerPeerWebSocket::get_message() { ERR_FAIL_COND_V(in_queue.is_empty(), Array()); - Array msg = in_queue.front()->get(); + Array msg = in_queue.get_front(); in_queue.pop_front(); return msg; } diff --git a/scene/2d/animated_sprite_2d.cpp b/scene/2d/animated_sprite_2d.cpp index 1cab29f38359..557b89e2ec91 100644 --- a/scene/2d/animated_sprite_2d.cpp +++ b/scene/2d/animated_sprite_2d.cpp @@ -304,7 +304,7 @@ void AnimatedSprite2D::set_sprite_frames(const Ref &p_frames) { autoplay = String(); } else { if (!frames->has_animation(animation)) { - set_animation(al.front()->get()); + set_animation(al.get_front()); } if (!frames->has_animation(autoplay)) { autoplay = String(); diff --git a/scene/3d/sprite_3d.cpp b/scene/3d/sprite_3d.cpp index 42460eec4cf7..674610fee999 100644 --- a/scene/3d/sprite_3d.cpp +++ b/scene/3d/sprite_3d.cpp @@ -1190,7 +1190,7 @@ void AnimatedSprite3D::set_sprite_frames(const Ref &p_frames) { autoplay = String(); } else { if (!frames->has_animation(animation)) { - set_animation(al.front()->get()); + set_animation(al.get_front()); } if (!frames->has_animation(autoplay)) { autoplay = String(); diff --git a/scene/debugger/scene_debugger.cpp b/scene/debugger/scene_debugger.cpp index 22e5238faefb..6ace0bb70642 100644 --- a/scene/debugger/scene_debugger.cpp +++ b/scene/debugger/scene_debugger.cpp @@ -510,7 +510,7 @@ SceneDebuggerTree::SceneDebuggerTree(Node *p_root) { const StringName &is_visible_sn = SNAME("is_visible"); const StringName &is_visible_in_tree_sn = SNAME("is_visible_in_tree"); while (stack.size()) { - Node *n = stack.front()->get(); + Node *n = stack.get_front(); stack.pop_front(); int count = n->get_child_count(); diff --git a/scene/resources/2d/skeleton/skeleton_modification_2d_physicalbones.cpp b/scene/resources/2d/skeleton/skeleton_modification_2d_physicalbones.cpp index 001000fa17ba..1385e5720294 100644 --- a/scene/resources/2d/skeleton/skeleton_modification_2d_physicalbones.cpp +++ b/scene/resources/2d/skeleton/skeleton_modification_2d_physicalbones.cpp @@ -194,7 +194,7 @@ void SkeletonModification2DPhysicalBones::fetch_physical_bones() { node_queue.push_back(stack->skeleton); while (node_queue.size() > 0) { - Node *node_to_process = node_queue.front()->get(); + Node *node_to_process = node_queue.get_front(); node_queue.pop_front(); if (node_to_process != nullptr) { diff --git a/servers/rendering/renderer_viewport.cpp b/servers/rendering/renderer_viewport.cpp index 4d6435f48a53..f0cb81de6ce0 100644 --- a/servers/rendering/renderer_viewport.cpp +++ b/servers/rendering/renderer_viewport.cpp @@ -102,7 +102,7 @@ Vector RendererViewport::_sort_active_viewports() } while (!nodes.is_empty()) { - const Viewport *node = nodes.front()->get(); + const Viewport *node = nodes.get_front(); nodes.pop_front(); for (int i = active_viewports.size() - 1; i >= 0; --i) { diff --git a/tests/core/object/test_object.h b/tests/core/object/test_object.h index e703698ec644..f941d40791ee 100644 --- a/tests/core/object/test_object.h +++ b/tests/core/object/test_object.h @@ -151,7 +151,7 @@ TEST_CASE("[Object] Core getters") { inheritance_list.size() == 1, "The inheritance list should consist of Object only"); CHECK_MESSAGE( - inheritance_list.front()->get() == "Object", + inheritance_list.get_front() == "Object", "The inheritance list should consist of Object only"); } diff --git a/tests/core/variant/test_dictionary.h b/tests/core/variant/test_dictionary.h index 48a48f6ca62b..1481075f8f75 100644 --- a/tests/core/variant/test_dictionary.h +++ b/tests/core/variant/test_dictionary.h @@ -104,7 +104,7 @@ TEST_CASE("[Dictionary] get_key_lists()") { map[1] = 3; map.get_key_list(ptr); CHECK(keys.size() == 1); - CHECK(int(keys.front()->get()) == 1); + CHECK(int(keys.get_front()) == 1); map[2] = 4; map.get_key_list(ptr); CHECK(keys.size() == 3);