Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Version detection of LoRA networks should check SAI ModelSpec keys #13319

Open
1 task done
Nerogar opened this issue Sep 18, 2023 · 0 comments
Open
1 task done
Labels
enhancement New feature or request

Comments

@Nerogar
Copy link
Contributor

Nerogar commented Sep 18, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

The version of LoRA networks is detected by network.detect_version() (in extensions-builtin/Lora/network.py). This function only checks for the keys ss_base_model_version and ss_v2. It would be great if this function could also check for modelspec.architecture key defined in https://github.com/Stability-AI/ModelSpec. Right now LoRAs that follow the SAI standard are not detected with the correct version.

Proposed workflow

If the keys ss_base_model_version and ss_v2 are not found, the function should check the modelspec.architecture key defined in https://github.com/Stability-AI/ModelSpec.

Additional information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant