Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ctrl + Up/Down does not recognize phrases by commas anymore #13443

Closed
1 task done
wbzy00 opened this issue Sep 30, 2023 · 1 comment · Fixed by #13444
Closed
1 task done

[Bug]: Ctrl + Up/Down does not recognize phrases by commas anymore #13443

wbzy00 opened this issue Sep 30, 2023 · 1 comment · Fixed by #13444
Labels
bug-report Report of a bug, yet to be confirmed

Comments

@wbzy00
Copy link

wbzy00 commented Sep 30, 2023

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What happened?

When using Ctrl + Up/Down to adjust the weight of a prompt phrase, it only recognizes single words instead of phrases based on commas. For example, when putting the mouse cursor near "extremely" in the prompt "girl, extremely detailed, grass", and pressing Ctrl + Up, the prompt will become "girl, (extremely:1.1) detailed, grass" instead of "girl, (extremely detailed:1.1) detailed, grass'.
This new behavior is inconvenient.

Steps to reproduce the problem

  1. Put the mouse cursor near "extremely" in the prompt "girl, extremely detailed, grass" in the prompt box.
  2. Press Ctrl + Up, you can see the prompt will become "girl, (extremely:1.1) detailed, grass" instead of "girl, (extremely detailed:1.1) detailed, grass'.

What should have happened?

When the mouse cursor is near "extremely" and pressing Ctrl + Up, the prompt should become "girl, (extremely detailed:1.1) detailed, grass'.

Sysinfo

sysinfo-2023-09-30-02-01.txt

What browsers do you use to access the UI ?

Chrome

Console logs

venv "E:\stable-diffusion-webui\venv\Scripts\Python.exe"
Python 3.10.6 (tags/v3.10.6:9c7b4bd, Aug  1 2022, 21:53:49) [MSC v.1932 64 bit (AMD64)]
Version: v1.6.0
Commit hash: 5ef669de080814067961f28357256e8fe27544f4
You are up to date with the most recent release.
Launching Web UI with arguments: --xformers --update-check --ad-no-huggingface --medvram-sdxl
Civitai Helper: Get Custom Model Folder
Civitai Helper: Load setting from: E:\stable-diffusion-webui\extensions\Stable-Diffusion-Webui-Civitai-Helper\setting.json
Civitai Helper: No setting file, use default
Tag Autocomplete: Could not locate model-keyword extension, Lora trigger word completion will be limited to those added through the extra networks menu.
[-] ADetailer initialized. version: 23.9.2, num models: 11
2023-09-30 10:26:22,511 - ControlNet - INFO - ControlNet v1.1.410
ControlNet preprocessor location: E:\stable-diffusion-webui\extensions\sd-webui-controlnet\annotator\downloads
2023-09-30 10:26:22,828 - ControlNet - INFO - ControlNet v1.1.410
sd-webui-prompt-all-in-one background API service started successfully.
Loading weights [fc2511737a] from E:\stable-diffusion-webui\models\Stable-diffusion\chilloutmix_NiPrunedFp32Fix.safetensors
Creating model from config: E:\stable-diffusion-webui\configs\v1-inference.yaml
E:\stable-diffusion-webui\extensions\sdweb-easy-prompt-selector\scripts\easy_prompt_selector.py:97: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  reload_button.style(size='sm')
E:\stable-diffusion-webui\extensions\stable-diffusion-webui-sonar\scripts\sonar.py:658: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  with gr.Row(variant='compact').style(equal_height=True):
E:\stable-diffusion-webui\extensions\sd-extension-system-info\scripts\system-info.py:451: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  refresh_quick_btn = gr.Button('Refresh state', elem_id = 'system_info_tab_refresh_btn', visible = False).style() # quick refresh is used from js interval
E:\stable-diffusion-webui\extensions\sd-extension-system-info\scripts\system-info.py:452: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  refresh_full_btn = gr.Button('Refresh data', elem_id = 'system_info_tab_refresh_full_btn', variant='primary').style()
E:\stable-diffusion-webui\extensions\sd-extension-system-info\scripts\system-info.py:504: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  bench_run_btn = gr.Button('Run benchmark', elem_id = 'system_info_tab_benchmark_btn', variant='primary').style()
E:\stable-diffusion-webui\extensions\sd-extension-system-info\scripts\system-info.py:506: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  bench_submit_btn = gr.Button('Submit results', elem_id = 'system_info_tab_submit_btn', variant='primary').style()
E:\stable-diffusion-webui\extensions\sd-extension-system-info\scripts\system-info.py:515: GradioDeprecationWarning: The `style` method is deprecated. Please set these arguments in the constructor instead.
  refresh_bench_btn = gr.Button('Refresh bench', elem_id = 'system_info_tab_refresh_bench_btn', visible = False).style(full_width = False) # quick refresh is used from js interval
E:\stable-diffusion-webui\extensions\sd-extension-system-info\scripts\system-info.py:515: GradioDeprecationWarning: Use `scale` in place of full_width in the constructor. scale=1 will make the button expand, whereas 0 will not.
  refresh_bench_btn = gr.Button('Refresh bench', elem_id = 'system_info_tab_refresh_bench_btn', visible = False).style(full_width = False) # quick refresh is used from js interval
Running on local URL:  http://127.0.0.1:7860

To create a public link, set `share=True` in `launch()`.
Startup time: 33.5s (prepare environment: 12.9s, import torch: 4.2s, import gradio: 2.8s, setup paths: 1.2s, initialize shared: 0.2s, other imports: 1.5s, setup codeformer: 0.2s, list SD models: 0.2s, load scripts: 3.3s, create ui: 1.5s, gradio launch: 2.7s, app_started_callback: 3.0s).
Applying attention optimization: xformers... done.
Model loaded in 12.5s (load weights from disk: 0.4s, create model: 1.2s, apply weights to model: 7.8s, apply half(): 1.4s, load VAE: 0.3s, load textual inversion embeddings: 0.1s, calculate empty prompt: 1.3s).

Additional information

I'm using Chrome on Windows 10

@wbzy00 wbzy00 added the bug-report Report of a bug, yet to be confirmed label Sep 30, 2023
@missionfloyd
Copy link
Collaborator

missionfloyd commented Sep 30, 2023

This new behavior is inconvenient.

That file hasn't been changed in three months. It's always used space as a delimiter.
https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/master/javascript/edit-attention.js

You can also select the specific text you want to adjust.
2023-09-30 22-00-51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-report Report of a bug, yet to be confirmed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants