-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Medical History capabilities #120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
============================================
+ Coverage 61.38% 63.04% +1.65%
- Complexity 491 516 +25
============================================
Files 94 94
Lines 1800 1870 +70
Branches 190 205 +15
============================================
+ Hits 1105 1179 +74
+ Misses 636 619 -17
- Partials 59 72 +13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like to check if changing the access modifier of arg multimap affects anything. Attributes should be private.
Also, how is medical history shown on UI now?
@@ -16,7 +16,7 @@ | |||
public class ArgumentMultimap { | |||
|
|||
/** Prefixes mapped to their respective arguments**/ | |||
private final Map<Prefix, List<String>> argMultimap = new HashMap<>(); | |||
public final Map<Prefix, List<String>> argMultimap = new HashMap<>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this attribute being changed to public? This violates OOP principles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshenx thank you! sorry, I changed to public to help the debugging process when I was failing test cases, forgot to change back. Pushed a new commit to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@joshenx this is how the MedicalHistory appears on GUI currently. Currently, there's only one medical entry within each medical history of all patients. Once there are more, it'll appear like this, "24 Oct 2021 | lovesick, 25 Oct 2021 | covid positive", separated by commas. |
This PR will add the following capabilities to the MedicalHistory class of the Patient:
date
of the medical entry to be the date the medical entry is recorded (i.e.LocalDate.now(Zone.Id.of(Singapore))
)EditPatientCommandParser
to break a patient's medical history into multiple medical entries, based on a CSV delimiter fashionParserUtil
to break a patient's medical history into multiple medical entries, based on a CSV delimiter fashionThis PR partially resolves #79