Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Prescription add/delete/list commands #136

Merged
merged 12 commits into from
Oct 26, 2021
Merged

Conversation

huyuxin0429
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2021

Codecov Report

Merging #136 (8239a8d) into master (2297f1c) will decrease coverage by 4.86%.
The diff coverage is 8.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #136      +/-   ##
============================================
- Coverage     60.35%   55.48%   -4.87%     
- Complexity      550      554       +4     
============================================
  Files           102      112      +10     
  Lines          2048     2251     +203     
  Branches        233      261      +28     
============================================
+ Hits           1236     1249      +13     
- Misses          728      918     +190     
  Partials         84       84              
Impacted Files Coverage Δ
...mmands/prescription/DeletePrescriptionCommand.java 0.00% <0.00%> (ø)
...ommands/prescription/ListPrescriptionsCommand.java 0.00% <0.00%> (ø)
...ress/logic/parser/AddAppointmentCommandParser.java 66.66% <0.00%> (-1.76%) ⬇️
.../seedu/address/logic/parser/AddressBookParser.java 100.00% <ø> (ø)
...du/address/logic/parser/AppointmentBookParser.java 40.00% <0.00%> (-17.15%) ⬇️
...ser/prescription/AddPrescriptionCommandParser.java 0.00% <0.00%> (ø)
.../prescription/DeletePrescriptionCommandParser.java 0.00% <0.00%> (ø)
...r/prescription/ListPrescriptionsCommandParser.java 0.00% <0.00%> (ø)
...seedu/address/model/prescription/Prescription.java 0.00% <0.00%> (ø)
...ion/exceptions/DuplicatePrescriptionException.java 0.00% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2297f1c...8239a8d. Read the comment docs.

@gycgabriel gycgabriel added this to the v1.3 milestone Oct 26, 2021
Copy link

@joshenx joshenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, just need to consider alternative function names for those I highlighted. Thanks for the hard work :)

Copy link

@joshenx joshenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty!

@joshenx joshenx merged commit f9deb2b into master Oct 26, 2021
@didymental didymental linked an issue Oct 26, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Prescriptions (enhanced) of Patients
4 participants