Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Auto-Archive feature and Sort Command #155

Merged
merged 4 commits into from
Oct 27, 2021
Merged

Conversation

joshenx
Copy link

@joshenx joshenx commented Oct 27, 2021

New Features

Expired Appointments

  • Expired appointment : Expired Appointments are appointments that are at least 24 hours past their scheduled DateTime.

Features

  • Added UI indicator for appointments that are scheduled today
  • Implement Comparable interface for Patient and Appointment classes
  • Added auto-archiving feature which archives EXPIRED appointments twice:
    1. On app launch
    2. Every day at a specified UPDATE_HOUR in the ModelManager class.
  • Generic sort command that sorts in the following priority:
    1. Appointment is today
    2. DateTime of appointment
    3. Name of Patient

To do

  • Requires changes to UserGuide
  • @didymental to implement parameter-based sorting

Bug Fixes

  • Fixed incorrect command prefix from appt to apmt.

Linked Issues

Closes #110 and closes #134

UI Example

image

@joshenx joshenx added this to the v1.3 milestone Oct 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #155 (3ed59c6) into master (2f541f0) will decrease coverage by 0.59%.
The diff coverage is 56.25%.

❗ Current head 3ed59c6 differs from pull request most recent head 07e08db. Consider uploading reports for the commit 07e08db to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #155      +/-   ##
============================================
- Coverage     53.33%   52.73%   -0.60%     
  Complexity      551      551              
============================================
  Files           116      117       +1     
  Lines          2325     2359      +34     
  Branches        268      269       +1     
============================================
+ Hits           1240     1244       +4     
- Misses          998     1028      +30     
  Partials         87       87              
Impacted Files Coverage Δ
src/main/java/seedu/docit/AppParameters.java 75.00% <ø> (ø)
src/main/java/seedu/docit/Main.java 0.00% <ø> (ø)
src/main/java/seedu/docit/MainApp.java 0.00% <0.00%> (ø)
src/main/java/seedu/docit/commons/core/Config.java 68.18% <ø> (ø)
...ain/java/seedu/docit/commons/core/GuiSettings.java 69.23% <ø> (ø)
...main/java/seedu/docit/commons/core/LogsCenter.java 78.37% <ø> (ø)
...c/main/java/seedu/docit/commons/core/Messages.java 0.00% <ø> (ø)
...rc/main/java/seedu/docit/commons/core/Version.java 82.50% <ø> (ø)
...ain/java/seedu/docit/commons/core/index/Index.java 100.00% <ø> (ø)
...it/commons/exceptions/DataConversionException.java 100.00% <ø> (ø)
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79dc783...07e08db. Read the comment docs.

@joshenx joshenx linked an issue Oct 27, 2021 that may be closed by this pull request
Copy link

@rish-16 rish-16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@rish-16 rish-16 merged commit 007c354 into master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Sort Command Appointments that happened already (1 day past) should be automatically archived
3 participants