Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation errors and prescription input/duplicate bug #232

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

huyuxin0429
Copy link

@huyuxin0429 huyuxin0429 commented Nov 1, 2021

Added check at parser level to only allow alphanumeric and certain characters:
Fixes #217
Fix addPrescription command to check the name of prescription when adding.
Fixes #210

Fix documentation bugs
Fixes #200
Fixes #198
Fixes #197
Fixes #196

@huyuxin0429 huyuxin0429 added the bugfix Fixes bug label Nov 1, 2021
@huyuxin0429 huyuxin0429 added this to the v1.4 milestone Nov 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

Merging #232 (d002a4c) into master (599f6ad) will decrease coverage by 0.08%.
The diff coverage is 22.22%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #232      +/-   ##
============================================
- Coverage     51.96%   51.87%   -0.09%     
  Complexity      552      552              
============================================
  Files           119      119              
  Lines          2413     2421       +8     
  Branches        271      273       +2     
============================================
+ Hits           1254     1256       +2     
- Misses         1068     1073       +5     
- Partials         91       92       +1     
Impacted Files Coverage Δ
...c/main/java/seedu/docit/commons/core/Messages.java 0.00% <ø> (ø)
...ava/seedu/docit/model/appointment/Appointment.java 32.25% <0.00%> (-2.23%) ⬇️
...va/seedu/docit/logic/parser/AddressBookParser.java 93.10% <50.00%> (-6.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599f6ad...d002a4c. Read the comment docs.

Copy link

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gycgabriel
Copy link

gycgabriel commented Nov 2, 2021

Unsure if this has been fixed as can't find relevant parser edits in files changed

Added check at parser level to only allow alphanumeric and certain characters:
Fixes #217

Copy link

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huyuxin0429 huyuxin0429 merged commit 47f1400 into master Nov 2, 2021
@huyuxin0429 huyuxin0429 linked an issue Nov 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment