Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context-menu font color and exit procedure #238

Merged
merged 3 commits into from
Nov 2, 2021
Merged

Conversation

joshenx
Copy link

@joshenx joshenx commented Nov 1, 2021

Closes #235
Closes #219

Preview

image

@joshenx joshenx added the bugfix Fixes bug label Nov 1, 2021
@joshenx joshenx added this to the v1.4 milestone Nov 1, 2021
@joshenx joshenx requested a review from gycgabriel November 1, 2021 18:12
@codecov-commenter
Copy link

Codecov Report

Merging #238 (e723ba0) into master (599f6ad) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #238      +/-   ##
============================================
- Coverage     51.96%   51.92%   -0.05%     
  Complexity      552      552              
============================================
  Files           119      119              
  Lines          2413     2413              
  Branches        271      271              
============================================
- Hits           1254     1253       -1     
- Misses         1068     1069       +1     
  Partials         91       91              
Impacted Files Coverage Δ
src/main/java/seedu/docit/model/ModelManager.java 65.94% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599f6ad...e723ba0. Read the comment docs.

@joshenx joshenx changed the title Fix context-menu font color Fix context-menu font color and exit procedure Nov 1, 2021
Copy link

@gycgabriel gycgabriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshenx joshenx merged commit 6843a6d into master Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

White font colour in popup when right clicking command box [PE-D] Cant exit with doc Exit
3 participants