Add tests to prescriptions #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into add-tests-to-prescriptions
…into add-tests-to-prescriptions
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
============================================
+ Coverage 54.02% 63.13% +9.10%
- Complexity 571 685 +114
============================================
Files 118 116 -2
Lines 2399 2555 +156
Branches 262 301 +39
============================================
+ Hits 1296 1613 +317
+ Misses 1021 831 -190
- Partials 82 111 +29
Continue to review full report at Codecov.
|
didymental
approved these changes
Nov 6, 2021
|
|
||
| if (medicineName.isBlank()) { | ||
| throw new ParseException("Medicine fields cannot be blank."); |
There was a problem hiding this comment.
For code quality:
- Can make this a public static variable like: MESSAGE_FAILURE
- then can re-reference this same message for the DeletePrescriptionCommandParserTest
| private final AddPrescriptionCommandParser parser = new AddPrescriptionCommandParser(); | ||
|
|
||
| @Test | ||
| public void parse_allFieldsPresent_success() throws ParseException { |
There was a problem hiding this comment.
Name should start with method name:
parseAppointmentCommnad_allFieldsPresent_success()
Same for the rest below
|
LGTM after code quality changes made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.