-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Developer Guide #282
Conversation
Codecov Report
@@ Coverage Diff @@
## master #282 +/- ##
============================================
+ Coverage 62.85% 65.76% +2.91%
- Complexity 650 691 +41
============================================
Files 116 116
Lines 2412 2445 +33
Branches 278 283 +5
============================================
+ Hits 1516 1608 +92
+ Misses 790 729 -61
- Partials 106 108 +2
Continue to review full report at Codecov.
|
docs/diagrams/ModelClassDiagram.puml
Outdated
Class MedicalEntry | ||
Class EntryList | ||
class "{abstract}\nEntry" as Entry | ||
class Entry.Some<MedicalEntry> MODEL_COLOR { | ||
} | ||
|
||
class Entry.Empty<Object> MODEL_COLOR { | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reduced detail by putting a note
|
||
The following activity diagram summarises what happens within `AddMedicalEntryCommandParser` when the user executes an Add Medical Entry command. | ||
|
||
![Activity diagram of Add Medical Entry Feature](diagrams/AddMedicalEntryFeatureActivityDiagram.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This diagram is repeated. Can similar structural diagrams be combined together?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we should have an activity diagram for each command since each command will have different scenarios / key things to take note of, even though the overall structure may be similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR resolves #267
Edit: PR is completed.