Fix AppointmentBook to accurately reflect changes in Patient details #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…whether update/removal
Codecov Report
@@ Coverage Diff @@
## master #97 +/- ##
============================================
- Coverage 63.03% 62.95% -0.08%
- Complexity 484 489 +5
============================================
Files 92 92
Lines 1718 1744 +26
Branches 175 180 +5
============================================
+ Hits 1083 1098 +15
- Misses 582 589 +7
- Partials 53 57 +4
Continue to review full report at Codecov.
|
gycgabriel
approved these changes
Oct 21, 2021
gycgabriel
reviewed
Oct 21, 2021
Comment on lines
+161
to
+176
| @Override | ||
| public void updateAppointmentBook(Patient target, Patient editedPatient) { | ||
| requireAllNonNull(target, editedPatient); | ||
|
|
||
| appointmentBook.updatePatient(target, editedPatient); | ||
| } | ||
|
|
||
| @Override | ||
| public void updateAppointmentBook(Patient target, boolean isPatientRemoval) { | ||
| if (isPatientRemoval) { | ||
| appointmentBook.removePatient(target); | ||
| } else { | ||
| logger.log(Level.INFO, "No changes were made to Patient name: " + target.getName()); | ||
| } | ||
| } | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
AppointmentBook does not reflect changes in Patient details, whether Patient is updated through
editordelete.We should update changes in Patient details in Appointments containing that Patient, and delete upcoming Appointments when a Patient is removed.
I have added methods in
Modelto update theAppointmentBookwhen theEditPatientCommandorDeletePatientCommandcommands is executed.I also fixed minor typos and errors in examples/parameters.
Closes #89.
Fixes #83.
Type of change: