Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix find and edit expense combined bug. #207

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

gitsac
Copy link

@gitsac gitsac commented Apr 3, 2023

Closes #160

@gitsac gitsac added this to the v1.4 milestone Apr 3, 2023
@@ -112,7 +112,7 @@ public CommandResult execute(Model model) throws CommandException {
}

Expense newExpense = new Expense(name, amount, date, category);
model.setExpense(targetIndex.getZeroBased(), newExpense);
model.setExpense(expenseToEdit, newExpense);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

Comment on lines +215 to 216
expenseTracker.setExpense(target, editedExpense);
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@shirsho-12 shirsho-12 merged commit bd658d6 into AY2223S2-CS2103T-W09-2:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester B] Find list does not update after edit
2 participants