Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PE-D][Tester D] Can input 3 digit phone numbers for supplier #210

Closed
soc-pe-bot opened this issue Mar 31, 2023 · 1 comment · Fixed by #267 or #276
Closed

[PE-D][Tester D] Can input 3 digit phone numbers for supplier #210

soc-pe-bot opened this issue Mar 31, 2023 · 1 comment · Fixed by #267 or #276
Assignees
@LiuMC-SG @HmuuMyatMoe
Labels
type.FeatureFlaw
Milestone
v1.4

Comments

@soc-pe-bot
Copy link

Screenshot 2023-03-31 at 2.21.59 PM.png

Labels: type.FunctionalityBug severity.Low
original: ongweijie7/ped#3
@LiuMC-SG
Copy link

LiuMC-SG commented Apr 2, 2023

Update to only allow for 8 digits.
Regex and UG

@LiuMC-SG LiuMC-SG mentioned this issue Apr 4, 2023
Merged
8 tasks
@LiuMC-SG LiuMC-SG added this to the v1.4 milestone Apr 4, 2023
@LiuMC-SG LiuMC-SG closed this as not planned Won't fix, can't repro, duplicate, stale Apr 5, 2023
@HmuuMyatMoe HmuuMyatMoe mentioned this issue Apr 6, 2023
Merged
@HmuuMyatMoe HmuuMyatMoe linked a pull request Apr 6, 2023 that will close this issue
Update UG #276
Merged
LiuMC-SG added a commit that referenced this issue Apr 7, 2023
@LiuMC-SG
Update UG (#276)
2451b37 
* Fixes #264, #220, #210, #206 
* Clarified requirements for deadline and phone number parameters 
* Clarified how duplicates are checked for
* Cosmetic changes made to make UG look neater
* Check UG format standardization (e.g. standardize `Syntax:`)
* Check that things written in UG matches with the app functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LiuMC-SG LiuMC-SG

@HmuuMyatMoe HmuuMyatMoe

Labels
type.FeatureFlaw
Projects
None yet
Milestone
v1.4
Development

Successfully merging a pull request may close this issue.

Update and Fix User Guide LiuMC-SG/tp
Update UG HmuuMyatMoe/tp
3 participants
@LiuMC-SG @HmuuMyatMoe @soc-pe-bot