Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up keywords in commands #246

Open
Pacmens opened this issue Jul 1, 2021 · 0 comments
Open

Clean up keywords in commands #246

Pacmens opened this issue Jul 1, 2021 · 0 comments
Assignees
Labels
code quality Improving the quality/maintainability of the code feature Functional additions to the code new command Adds a new command to hera

Comments

@Pacmens
Copy link
Collaborator

Pacmens commented Jul 1, 2021

There is certain commands like the help command that allow for keywords to be used.

For example you can write $help all and get all the commands even though they might not be enabled or usable.

Currently this is handeled through hardcoded stringcompares in the method and is always set to the same value.

It would be better to have a way to set aliases on these as well as having a generic way to handle this inputs that will take this into consideration so it doesnt have to be hardcoded everywhere.

This would also require a command that can set these aliases per server in the commands it affects

@Pacmens Pacmens added enhancement concept Conceptual work for functionality labels Jul 1, 2021
@Pacmens Pacmens self-assigned this Jul 1, 2021
@Pacmens Pacmens added code quality Improving the quality/maintainability of the code feature Functional additions to the code new command Adds a new command to hera duplicate If you dont have a mirror but still wanna see wontfix You think we should? Don't care! and removed maintenance concept Conceptual work for functionality duplicate If you dont have a mirror but still wanna see wontfix You think we should? Don't care! labels Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improving the quality/maintainability of the code feature Functional additions to the code new command Adds a new command to hera
Projects
None yet
Development

No branches or pull requests

1 participant