Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code and functionality cleanup #247

Open
11 tasks
Pacmens opened this issue Jul 1, 2021 · 0 comments
Open
11 tasks

Code and functionality cleanup #247

Pacmens opened this issue Jul 1, 2021 · 0 comments
Assignees
Labels
feature Functional additions to the code

Comments

@Pacmens
Copy link
Collaborator

Pacmens commented Jul 1, 2021

The bot has gone through numerous changes over the time of development most recently an update of the versions of lavaplayer and discord4j.

This is a great time to also bring up other things that might be slightly outdated.

It should also be taken as an opertunity to go over the code and functionality and clean it up. This should include:

  • Update all framework dependency versions and if needed change code to comply with their changes
  • Extend package structure to improve locatability of items
  • Remove hardcoded variables to constants, create classes to gather constants where reasonable
  • Change functionality of commands where necessary to ensure internal consistency
  • Cut down on redundant code by:
  • Cleaning up class, package and variable naming
  • Cleaning up the HeraUtil class #269
  • Bettering the code documentation #256 Improve code documentation
@Pacmens Pacmens self-assigned this Jul 1, 2021
@Pacmens Pacmens added the feature Functional additions to the code label Jul 9, 2021
@Pacmens Pacmens added this to the Hera Beta Cleanup milestone Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Functional additions to the code
Projects
None yet
Development

No branches or pull requests

1 participant