Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug for Quantity Change Modal #46

Open
kyl-dc opened this issue Apr 8, 2022 · 0 comments
Open

Bug for Quantity Change Modal #46

kyl-dc opened this issue Apr 8, 2022 · 0 comments

Comments

@kyl-dc
Copy link
Collaborator

kyl-dc commented Apr 8, 2022

When selecting an item that was added before the latest one, the quantity change modal that opens up ends up being blocked by some elements on the screen. This might be because the FlatList item z-index follows the ordering of items as they're added, so clicking a previously added item shows this:

Screen Shot 2022-04-08 at 4 43 19 PM

Steps to replicate:

  • checkout 39_quantityChangeModal
  • Add item 3 and item 4 with some tags
  • Select the quantity field on item 2

Solution Approach:
Find a way to make the selected item's z-index greater than the other list items, so it stays on top of the screen. OR, Find a way to re-implement how we show our listItems without using FlatList.
I found this issue as well: facebook/react-native#28751
Here, there's a proposed solution by bboure on Aug 22, 2020 maybe try something like that.

Additional Changes:

  • Fix the the quantity styling so that it's identical for both the AddItemModal and the QuantityChangeModal, with subtract on the left. ie. (-) 1 (+)

  • Make sure that the subtract (-) button is greyed-out when it hits 1, as quantities need to be >0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant