#13: QueryResultRow conversion for Product types #36

benedeki · 2024-09-25T17:27:30Z

implicit class that adds the ability to convert QueryResultRow to a product type
implicit classes that add getOrThrow methods to Option and Map
copied NamingConvention classes from Fa-DB
added sbt testAll alias
enhanced the README.md to include some basic classes of the library used for DB testing

Closes #13

* implicit class that adds the ability to convert `QueryResultRow` to a product type * implicit classes that add `getOrThrow` methods to `Option` and `Map` * copied `NamingConvention` classes from Fa-DB * added `sbt testAll` alias * enhanced the README.md to include some basic classes of the library used for DB testing

miroslavpojer

pull
code review
run all test types

README.md

balta/src/main/scala/za/co/absa/db/balta/implicits/QueryResultRowImplicits.scala

balta/src/test/resources/db/postgres/08_testing.simple_function.sql

balta/src/test/scala/za/co/absa/db/balta/implicits/MapImplicitsUnitTests.scala

...a/src/test/scala/za/co/absa/db/balta/implicits/QueryResultRowImplicitsIntegrationTests.scala

balta/src/test/scala/za/co/absa/db/mag/naming/implementations/AsIsNamingUnitTests.scala

balta/src/test/scala/za/co/absa/db/mag/naming/implementations/SnakeCaseNamingUnitTests.scala

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>

…roduct-types

github-actions · 2024-09-29T04:20:18Z

JaCoCo 'balta' module code coverage report - scala 2.12.18

Overall Project	46.73% `-18.82%`	🍏
Files changed	52.54%	🍏

File	Coverage
NamingException.scala	100%	🍏
MapBasedNaming.scala	100% `-17.78%`	🍏
QueryResultRow.scala	92.33%	🍏
SnakeCaseNaming.scala	87.14% `-12.86%`	🍏
LettersCase.scala	85.29%	🍏
NamingConvention.scala	80.77% `-19.23%`	🍏
QueryResultRowImplicits.scala	74.27% `-62.57%`	🍏
ExplicitNamingRequired.scala	55% `-65%`	🍏
AsIsNaming.scala	40.63% `-84.38%`	🍏
MapImplicits.scala	30.43%	🍏

README.md

lsulak · 2024-10-01T10:05:27Z

balta/src/main/scala/za/co/absa/db/balta/classes/QueryResultRow.scala

@@ -35,7 +36,10 @@ class QueryResultRow private[classes](val rowNumber: Int,
                                      private val columnNames: FieldNames) {

  def columnCount: Int = fields.length
-  def columnNumber(columnLabel: String): Int = columnNames(columnLabel.toLowerCase)
+  def columnNumber(columnLabel: String): Int = {


why Label terminology?

Original terminology from JDBC

but it's column name right?

Hmm I read here that it's this: https://bugs.mysql.com/bug.php?id=35610

so alias or column name. Not sure if in our case it's always only column name?

Look at the ResultSet class methods.

Hmm I still don't fully know the answer if you think deeper into it (i.e. whether both can be applied to our case or only column name) :D

https://docs.oracle.com/javase/7/docs/api/java/sql/ResultSet.html

E.g.

columnLabel - the label for the column specified with the SQL AS clause. If the SQL AS clause was not specified, then the label is the name of the column

Column names used as input to getter methods are case insensitive. When a getter method is called with a column name and several columns have the same name, the value of the first matching column will be returned. The column name option is designed to be used when column names are used in the SQL query that generated the result set. For columns that are NOT explicitly named in the query, it is best to use column numbers. If column names are used, the programmer should take care to guarantee that they uniquely refer to the intended columns, which can be assured with the SQL AS clause.

Okay, we can follow it. But maybe at least document it super briefly? That this terminology is coming from X with some link perhaps etc

(Basically, if we are using an underlying technology A that is using special terminology B for something that uses X and Y, and X is known thing - in our case column name - and if we are not using Y, then it makes sense not to follow A's way by using B, just use X; special-ish undocumented terms are never a good thing in my opinion)

Can you please suggest the documentation text. I am not sure I follow.

balta/src/test/resources/db/postgres/08_testing.simple_function.sql

Co-authored-by: Ladislav Sulak <laco.sulak@gmail.com>

…roduct-types

benedeki · 2024-10-01T13:37:06Z

balta/src/main/scala/za/co/absa/db/balta/implicits/QueryResultRowImplicits.scala

+
+    private def getParamValue[T: TypeTag](columnLabel: String, expectedType: Type): Any = {
+      val value = row(columnLabel)
+      if (isOptionType(expectedType)) {


Here, deciding how to pass in the actual value to the constructor.

benedeki requested review from miroslavpojer, lsulak and salamonpavel as code owners September 25, 2024 17:27

* added "simple function" into the build GitHub workflow

77f32c6

miroslavpojer reviewed Sep 26, 2024

View reviewed changes

benedeki and others added 2 commits September 26, 2024 16:43

Apply suggestions from code review

31bbaa5

Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>

* removed unused import

66538ab

miroslavpojer previously approved these changes Sep 27, 2024

View reviewed changes

benedeki and others added 3 commits September 27, 2024 22:49

Merge branch 'master' into feature/13-queryresultrow-conversion-for-p…

5c3fca8

…roduct-types

Merge branch 'master' into feature/13-queryresultrow-conversion-for-p…

e61c4a9

…roduct-types

* updated JaCoCo workflow

136369a

benedeki dismissed miroslavpojer’s stale review via 136369a September 29, 2024 04:19

lsulak reviewed Oct 1, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

lsulak reviewed Oct 1, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

lsulak reviewed Oct 1, 2024

View reviewed changes

balta/src/test/resources/db/postgres/08_testing.simple_function.sql Outdated Show resolved Hide resolved

benedeki and others added 2 commits October 1, 2024 13:22

Apply suggestions from code review

0b319a4

Co-authored-by: Ladislav Sulak <laco.sulak@gmail.com>

Merge branch 'master' into feature/13-queryresultrow-conversion-for-p…

6abf5fa

…roduct-types

benedeki commented Oct 1, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#13: QueryResultRow conversion for Product types #36

#13: QueryResultRow conversion for Product types #36

benedeki commented Sep 25, 2024

miroslavpojer left a comment

github-actions bot commented Sep 29, 2024 •

edited

Loading

lsulak Oct 1, 2024

benedeki Oct 1, 2024

lsulak Oct 1, 2024

lsulak Oct 1, 2024

benedeki Oct 1, 2024

lsulak Oct 1, 2024 •

edited

Loading

lsulak Oct 1, 2024 •

edited

Loading

benedeki Oct 1, 2024

benedeki Oct 1, 2024

#13: QueryResultRow conversion for Product types #36

Are you sure you want to change the base?

#13: QueryResultRow conversion for Product types #36

Conversation

benedeki commented Sep 25, 2024

miroslavpojer left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024 • edited Loading

JaCoCo 'balta' module code coverage report - scala 2.12.18

lsulak Oct 1, 2024

Choose a reason for hiding this comment

benedeki Oct 1, 2024

Choose a reason for hiding this comment

lsulak Oct 1, 2024

Choose a reason for hiding this comment

lsulak Oct 1, 2024

Choose a reason for hiding this comment

benedeki Oct 1, 2024

Choose a reason for hiding this comment

lsulak Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

lsulak Oct 1, 2024 • edited Loading

Choose a reason for hiding this comment

benedeki Oct 1, 2024

Choose a reason for hiding this comment

benedeki Oct 1, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 29, 2024 •

edited

Loading

lsulak Oct 1, 2024 •

edited

Loading

lsulak Oct 1, 2024 •

edited

Loading