#33: Make execution of function without verification easier #34
+18
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedeki
requested review from
miroslavpojer,
lsulak and
salamonpavel
as code owners
lsulak
previously approved these changes
Sep 11, 2024
miroslavpojer
previously approved these changes
Sep 11, 2024
* new function `getResult` which returns the list of function outputs
balta/src/main/scala/za/co/absa/db/balta/classes/DBFunction.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>
balta/src/main/scala/za/co/absa/db/balta/classes/DBFunction.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: miroslavpojer <miroslav.pojer@absa.africa>
miroslavpojer
approved these changes
Sep 11, 2024
…out-verification-easier
JaCoCo 'balta' module code coverage report - scala 2.12.18
|
lsulak
reviewed
Oct 1, 2024
| * @param orderBy - the clause how to order the function result, if empty, default ordering is preserved | ||
| * @param connection - the database connection | ||
| */ | ||
| def getResult(orderBy: String = "")(implicit connection: DBConnection): List[QueryResultRow] = { |
There was a problem hiding this comment.
TIny
The orderBy 'API' is different in this function and in the execute function. That I find a little bit confusing from users' point of view. Perhaps as they are sharing similar ideas should have similar APIs.
So I would consider making it default also in def execute[R](orderBy: String) (such change is backward compatible and also doesn't overwhelm the user thus probably more preferred variant).
There was a problem hiding this comment.
Also I would document / provide an example of orderBy content, because it's not the full clause (ORDER BY is already provided on line 88)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBFunction.perfromadded, intention to just execute the function without care for result, just the side-effectDBFunction.getResultwhich execute the function and returns the list of its outputsNote:
Yes,
getResultcould also have a version to return a Scala case class list, as #13 suggests. But it's beyond the scope of this simple PR.Closes #33