Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Element Equivalence Interfaces #2003

Merged
merged 37 commits into from
Oct 7, 2024
Merged

Add Element Equivalence Interfaces #2003

merged 37 commits into from
Oct 7, 2024

Commits on Sep 4, 2024

  1. Working version of isEquivalent().

    @kwokcb
    kwokcb committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    97c9ff2 View commit details
    Browse the repository at this point in the history

  2. Add option to perform literal string vs value comparisons.

    @kwokcb
    kwokcb committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    59bacd8 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Review updates: 

    - Separate out results into option results class argument.
- Add isAttributeEquivalent() to avoid duplication
    @kwokcb
    kwokcb committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a5a3627 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. Add in underered child testing. Refine result struct.

    @kwokcb
    kwokcb committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    7791d18 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2024

  1. Fix test

    @kwokcb
    kwokcb committed Sep 7, 2024
    Configuration menu
    Copy the full SHA
    126600e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into value_equivalent

    @kwokcb
    kwokcb authored Sep 7, 2024
    Configuration menu
    Copy the full SHA
    3104481 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2024

  1. Remove attribute order option. Add in functional graph ordering check.

    @kwokcb
    kwokcb committed Sep 8, 2024
    Configuration menu
    Copy the full SHA
    ba70b52 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. Remove extra newline

    @jstone-lucasfilm
    jstone-lucasfilm authored Sep 25, 2024
    Configuration menu
    Copy the full SHA
    bb7507d View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. Review fixes. 

    - Use const instead of non-const
- Fix formatting
- Get rid of uneeded bool.
- Fix up naming of c1, c2
    @kwokcb
    kwokcb committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    2216af5 View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2024

  1. Review updates. 

    Review Updates
- Revert operator== name changes
- Change c2Element to rhsElement.
    @kwokcb
    kwokcb committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    e8a71cf View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2024

  1. Merge branch 'main' into value_equivalent

    @kwokcb
    kwokcb authored Sep 30, 2024
    Configuration menu
    Copy the full SHA
    d33cb84 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. Merge branch 'main' into value_equivalent

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 1, 2024
    Configuration menu
    Copy the full SHA
    5c48623 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Add Python bindings for new APIs.

    @kwokcb
    kwokcb committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    eab74b1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into value_equivalent

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    af3c1fc View commit details
    Browse the repository at this point in the history

  3. Minor spelling fixes

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    160c7b1 View commit details
    Browse the repository at this point in the history

  4. Remove extra header include

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    eb9c6f7 View commit details
    Browse the repository at this point in the history

  5. Minor formatting fixes

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 3, 2024
    Configuration menu
    Copy the full SHA
    ec8342f View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. Review fixes: 

    - Cleanup single result class to be structures. Create a vector class for this.
- Fix Python bindings to return [ status, result } pair.
- Fixed a logic regression. Previous changed removed non-value compare in ValueElement::isAttributeEquivalent()
    @kwokcb
    kwokcb committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4eb7ffe View commit details
    Browse the repository at this point in the history

  2. Group constants for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 4, 2024
    Configuration menu
    Copy the full SHA
    e1f6e4f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. Review update 

    - Rename ElementEquivalenceResults to ElementEquivalenceResultVec
    @kwokcb
    kwokcb committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    7733ec8 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2024

  1. Merge branch 'main' into value_equivalent

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    e258aa7 View commit details
    Browse the repository at this point in the history

  2. Remove extra line

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    4e40efd View commit details
    Browse the repository at this point in the history

  3. Refactor header for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    bbc7dbe View commit details
    Browse the repository at this point in the history

  4. Remove extra line

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    a990049 View commit details
    Browse the repository at this point in the history

  5. Reorder for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    734b567 View commit details
    Browse the repository at this point in the history

  6. Reorder for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    11d8a01 View commit details
    Browse the repository at this point in the history

  7. Clarify language

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    9dd9ef3 View commit details
    Browse the repository at this point in the history

  8. Reorder for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    f9744ef View commit details
    Browse the repository at this point in the history

  9. Remove duplicate qualifier

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    7b58cea View commit details
    Browse the repository at this point in the history

  10. Minor spelling fix

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 6, 2024
    Configuration menu
    Copy the full SHA
    fb24722 View commit details
    Browse the repository at this point in the history

  11. Remove erronesous extra declaration.

    @kwokcb
    kwokcb committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    8ee6a3b View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Simplify using range-based for loop

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    def7db6 View commit details
    Browse the repository at this point in the history

  2. Clarify variable names and docs

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    fbab4bc View commit details
    Browse the repository at this point in the history

  3. Clarify variable names

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    1784427 View commit details
    Browse the repository at this point in the history

  4. Use consistent order in C++/Python

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    5ab964b View commit details
    Browse the repository at this point in the history

  5. Minor reorder for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9609d1d View commit details
    Browse the repository at this point in the history

  6. Minor reorder for clarity

    @jstone-lucasfilm
    jstone-lucasfilm authored Oct 7, 2024
    Configuration menu
    Copy the full SHA
    bb9d8be View commit details
    Browse the repository at this point in the history