Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add in Javascript bindings for equivalence API #2126

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add in Javascript bindings for equivalence API #2126

wants to merge 2 commits into from

Conversation

kwokcb
Copy link
Contributor

@kwokcb kwokcb commented Nov 27, 2024

Change

  • Expose the Element::isEquivalent() + options structure API in Javascript.
  • Results class not exposed to avoid undue complexity (*)

Tests

  • New unit test added which performs the same tests as the C++ unit tests.
  • e.g. from test with one resulting messge printed out:
-  Equivalence
   - Path: mygraph/input_color3 differs from path: mygraph/input_color3. Difference Type: attribute. Attribute: value.

(*) @jstone-lucasfilm : A string is built and returned, following the approach used for Element::validate().

@kwokcb kwokcb changed the title Ad in Javascript bindings for equivalence API Add in Javascript bindings for equivalence API Nov 27, 2024
@kwokcb kwokcb mentioned this pull request Nov 27, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kwokcb