Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specular_tint? #66

Closed
portsmouth opened this issue Aug 4, 2023 · 4 comments
Closed

specular_tint? #66

portsmouth opened this issue Aug 4, 2023 · 4 comments

Comments

@portsmouth
Copy link
Contributor

@brechtvl wrote:

For non-physical color multiplier like specular_color and transmission_color (with depth 0), we called those "tint" instead of "color" to make a more clear distinction with the physical ones like base_color.

@portsmouth
Copy link
Contributor Author

Agree that specular_color would work better as specular_tint. This would nicely tie with the F82-tint model for the conductor as well, where this color specifies F82 as a tint of the Schlick reflectance. This also distinguishes it from coat_color, which does not tint the coat highlight (it colors the substrate lobe due to absorption in the coat).

@portsmouth
Copy link
Contributor Author

@peterkutz wrote:

For non-physical color multiplier like specular_color and transmission_color (with depth 0), we called those "tint" instead of "color" to make a more clear distinction with the physical ones like base_color.

Makes sense. We almost did that in ASM too. I forget why we didn't.

@virtualzavie
Copy link
Contributor

This didn't make consensus during our meeting discussion, as it's not clear where the distinction is between "color" and "tint", so we decided to not change and keep using "color".

@brechtvl
Copy link
Contributor

brechtvl commented Oct 9, 2023

Ok, it was only a minor suggestion, I guess this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants